Page MenuHomePhabricator

Improve error handling for Aphlict.
ClosedPublic

Authored by joshuaspence on Jun 7 2014, 10:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 1:08 PM
Unknown Object (File)
Fri, Nov 22, 7:13 AM
Unknown Object (File)
Tue, Nov 19, 1:16 PM
Unknown Object (File)
Oct 19 2024, 4:22 AM
Unknown Object (File)
Oct 16 2024, 10:41 PM
Unknown Object (File)
Oct 13 2024, 2:48 AM
Unknown Object (File)
Oct 12 2024, 10:22 AM
Unknown Object (File)
Oct 12 2024, 9:05 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP7d255aedba43: Improve error handling for Aphlict.
Summary

Currently, any error thrown when instantiating an AphlictMaster will be assumed to be due to the master already existing. This is a bit overzealous because the documentation specifically states than an ArgumentError will be throw if "the LocalConnection instance is already connected".

Test Plan

Inspected the log message.

Diff Detail

Repository
rP Phabricator
Branch
aphlict-argerror
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 922
Build 922: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve error handling for Aphlict..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2014, 10:16 PM
epriestley updated this revision to Diff 22503.

Closed by commit rP7d255aedba43 (authored by @joshuaspence, committed by @epriestley).