Paths

Table of Contentst

Differential D9363

Don't redraw the console progress bar every time
ClosedPublic
Actions

Authored by epriestley on Jun 3 2014, 6:20 PM.

Tags

None

Referenced Files

	F13230881: D9363.diff
	Mon, May 20, 11:23 PM

	F13228245: D9363.id22296.diff
	Mon, May 20, 8:13 AM

	F13214251: D9363.id22295.diff
	Fri, May 17, 9:33 AM

	F13207364: D9363.diff
	Wed, May 15, 10:30 PM

	F13188729: D9363.diff
	Sat, May 11, 5:26 AM

	Unknown Object (File)
	Tue, May 7, 7:30 AM

	Unknown Object (File)
	Fri, May 3, 8:11 AM

	Unknown Object (File)
	Wed, Apr 24, 10:47 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T5255: Batch up SQL operations in the `./bin/repository parents` script

Commits

rPHU1e025a87a4cb: Don't redraw the console progress bar every time

Summary

lulululuul see D9361

Test Plan

derp derp derp

Diff Detail

Repository

Branch

barspeeed

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 831
Build 831: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22294.Jun 3 2014, 6:20 PM

epriestley retitled this revision from to Don't redraw the console progress bar every time.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 3 2014, 6:20 PM

Only set lastUpdate if we actually draw.

Harbormaster completed remote builds in B829: Diff 22294.Jun 3 2014, 6:21 PM

Harbormaster completed remote builds in B830: Diff 22295.

Slightly smoother bar (100ms / update instead of 200ms).

Harbormaster completed remote builds in B831: Diff 22296.Jun 3 2014, 6:23 PM

LGTM.

This makes the progress bar a little jerky, but I'd rather the progress bar be jerky than have the ./bin/repository parents script run 127 times slower.

This revision is now accepted and ready to land.Jun 3 2014, 6:24 PM

Closed by commit rPHU1e025a87a4cb (authored by @epriestley).

Thanks for the fix

epriestley mentioned this in D19506: Add --quiet flag to rebuild-identities.Aug 2 2018, 4:14 PM

Revision Contents
Changeset List

Path

Size

src/

console/

PhutilConsoleProgressBar.php

8 lines

Diff 22296

src/console/PhutilConsoleProgressBar.php

Loading...