Page MenuHomePhabricator

Execute the `./bin/search index` workflow in the background by default.
AbandonedPublic

Authored by joshuaspence on Jun 3 2014, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 9:33 PM
Unknown Object (File)
Dec 12 2024, 6:41 AM
Unknown Object (File)
Nov 26 2024, 7:41 PM
Unknown Object (File)
Nov 23 2024, 1:59 PM
Unknown Object (File)
Nov 21 2024, 8:56 PM
Unknown Object (File)
Nov 18 2024, 7:22 AM
Unknown Object (File)
Nov 14 2024, 2:46 PM
Unknown Object (File)
Nov 10 2024, 5:50 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Currently, ./bin/search index will rebuild search indexes in the current process, which is much slower than with the --background flag.

Test Plan

Ran ./bin/search index and verified that the tasks for queued for the daemon workers.

Diff Detail

Repository
rP Phabricator
Branch
search-index
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 827
Build 827: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Execute the `./bin/search index` workflow in the background by default..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

I think foreground indexing is the right default: it's confusing for bin/search index to exit successfully but not have actually rebuilt indexes, and it makes analyzing or debugging indexing issues more difficult. If there is an actual bug, this may queue a large number of immediately-fataling tasks.

I'd rather address this in other ways, like:

  • call out --background in the documentation; or
  • use a progress bar instead of printing out a line per object, and call out --background in the preamble.
In D9362#6, @epriestley wrote:

I think foreground indexing is the right default: it's confusing for bin/search index to exit successfully but not have actually rebuilt indexes, and it makes analyzing or debugging indexing issues more difficult. If there is an actual bug, this may queue a large number of immediately-fataling tasks.

I'd rather address this in other ways, like:

  • call out --background in the documentation; or
  • use a progress bar instead of printing out a line per object, and call out --background in the preamble.

Sounds reasonable to me. Let me try to come up with something.