Currently, ./bin/search index will rebuild search indexes in the current process, which is much slower than with the --background flag.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
Ran ./bin/search index and verified that the tasks for queued for the daemon workers.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- search-index
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 827 Build 827: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think foreground indexing is the right default: it's confusing for bin/search index to exit successfully but not have actually rebuilt indexes, and it makes analyzing or debugging indexing issues more difficult. If there is an actual bug, this may queue a large number of immediately-fataling tasks.
I'd rather address this in other ways, like:
- call out --background in the documentation; or
- use a progress bar instead of printing out a line per object, and call out --background in the preamble.