Page MenuHomePhabricator
Differential D9317

Add a version number to `ArcanistXHPASTLinter`.
ClosedPublic
Actions

Authored by joshuaspence on May 28 2014, 9:09 AM.
Tags
None
Referenced Files
F19071965: D9317.id.diff
Nov 30 2025, 9:03 PM
F18809666: D9317.id22110.diff
Oct 19 2025, 3:56 PM
F18618347: D9317.diff
Sep 14 2025, 11:52 PM
F18606995: D9317.diff
Sep 13 2025, 11:07 PM
F18590984: D9317.diff
Sep 12 2025, 7:52 AM
F18458898: D9317.diff
Sep 1 2025, 3:40 PM
F18366109: D9317.id22115.diff
Aug 27 2025, 9:55 PM
F18365895: D9317.id22115.diff
Aug 27 2025, 9:34 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5209: Add a version number to `ArcanistXHPASTLinter`
Commits
rARC7b61faa1927e: Add a version number to `ArcanistXHPASTLinter`.
Summary

Fixes T5209. It makes sense for the ArcanistXHPASTLinter to implement the getVersion method in order to be able to enforce version requirements (as in T4954).

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
xhpast-version
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 740
Build 740: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22110.May 28 2014, 9:09 AM
joshuaspence retitled this revision from to Add a version number to `ArcanistXHPASTLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5209: Add a version number to `ArcanistXHPASTLinter`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 28 2014, 9:09 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B740: Diff 22110.May 28 2014, 9:10 AM
epriestley accepted this revision.May 28 2014, 1:33 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2014, 1:33 PM
epriestley closed this revision.May 28 2014, 1:34 PM
epriestley updated this revision to Diff 22115.

Closed by commit rARC7b61faa1927e (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Diff 22110

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility