Page MenuHomePhabricator
Differential D9317

Add a version number to `ArcanistXHPASTLinter`.
ClosedPublic
Actions

Authored by joshuaspence on May 28 2014, 9:09 AM.
Tags
None
Referenced Files
F13194535: D9317.diff
Sun, May 12, 9:38 PM
F13177119: D9317.diff
Wed, May 8, 7:26 PM
Unknown Object (File)
Wed, Apr 24, 11:10 PM
Unknown Object (File)
Apr 17 2024, 6:57 PM
Unknown Object (File)
Apr 16 2024, 8:44 AM
Unknown Object (File)
Apr 12 2024, 1:45 PM
Unknown Object (File)
Apr 1 2024, 6:25 AM
Unknown Object (File)
Mar 10 2024, 6:12 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5209: Add a version number to `ArcanistXHPASTLinter`
Commits
rARC7b61faa1927e: Add a version number to `ArcanistXHPASTLinter`.
Summary

Fixes T5209. It makes sense for the ArcanistXHPASTLinter to implement the getVersion method in order to be able to enforce version requirements (as in T4954).

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22110.May 28 2014, 9:09 AM
joshuaspence retitled this revision from to Add a version number to `ArcanistXHPASTLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5209: Add a version number to `ArcanistXHPASTLinter`.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 28 2014, 9:09 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B740: Diff 22110.May 28 2014, 9:10 AM
epriestley accepted this revision.May 28 2014, 1:33 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 28 2014, 1:33 PM
epriestley closed this revision.May 28 2014, 1:34 PM
epriestley updated this revision to Diff 22115.

Closed by commit rARC7b61faa1927e (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Diff 22115

View Options

src/lint/linter/ArcanistBaseXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistPhutilXHPASTLinter.php

Loading...
View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
Phabricator · Built by Phacility