Paths

Table of Contentst

Differential D9295

Allow `FileFinder` to find paths which match a given path exactly.
ClosedPublic
Actions

Authored by joshuaspence on May 25 2014, 10:10 PM.

Tags

None

Referenced Files

	F14356630: D9295.diff
	Thu, Dec 19, 10:47 PM

	F14356542: D9295.diff
	Thu, Dec 19, 9:48 PM

	Unknown Object (File)
	Sun, Dec 15, 4:48 AM

	Unknown Object (File)
	Sun, Dec 15, 4:48 AM

	Unknown Object (File)
	Sun, Dec 15, 4:48 AM

	Unknown Object (File)
	Sun, Dec 15, 4:30 AM

	Unknown Object (File)
	Sun, Dec 15, 4:13 AM

	Unknown Object (File)
	Sat, Dec 14, 3:44 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings

Commits

rPHUefa928f70307: Allow `FileFinder` to find paths which match a given path exactly.

Summary

Ref T5105. This functionality is required in order to discover all .editorconfig files.

Test Plan

Wrote and executed unit tests.

Diff Detail

Repository

Branch

filefinder

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 715
Build 715: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22063.May 25 2014, 10:10 PM

joshuaspence retitled this revision from to Allow `FileFinder` to find paths which match a given path exactly..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 25 2014, 10:10 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B706: Diff 22063.May 25 2014, 10:12 PM

Two janitorial inlines.

src/filesystem/FileFinder.php
111–117	pls 2 clarifying parens T.T or `count() \|\| count()`?
227	This should probably be `array_merge()`? The initial elements of `suffix` will be overwritten: $ php -r "print_r(array('example.js') + array('.js'));" Array ( [0] => example.js )

This revision now requires changes to proceed.May 26 2014, 5:25 PM

Minor changes, as requested by @epriestley

Harbormaster completed remote builds in B715: Diff 22076.May 26 2014, 9:41 PM

epriestley accepted this revision.May 27 2014, 11:36 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 27 2014, 11:36 PM

Closed by commit rPHUefa928f70307 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

filesystem/

23 lines

__tests__/

FileFinderTestCase.php

69 lines

data/

exclude/

1 line

include_dir.txt/

subdir.txt/

1 line

1 line

Diff 22076

src/filesystem/FileFinder.php

Loading...

src/filesystem/tests/FileFinderTestCase.php

Loading...

src/filesystem/tests/data/exclude/test

Loading...

src/filesystem/tests/data/include_dir.txt/subdir.txt/test

Loading...

src/filesystem/tests/data/include_dir.txt/test

Loading...