Page MenuHomePhabricator
Differential D9292

Allow modern hunks to be stored deflated
ClosedPublic
Actions

Authored by epriestley on May 25 2014, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 6:57 PM
Unknown Object (File)
Sat, Apr 20, 1:01 PM
Unknown Object (File)
Thu, Apr 18, 8:01 PM
Unknown Object (File)
Wed, Apr 17, 3:14 PM
Unknown Object (File)
Fri, Apr 12, 11:33 PM
Unknown Object (File)
Fri, Apr 12, 8:01 AM
Unknown Object (File)
Sat, Apr 6, 4:40 PM
Unknown Object (File)
Mon, Apr 1, 1:40 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
T5179: Unearth Differential rendering technical debt
Commits
Restricted Diffusion Commit
rP4b39fbe1155e: Allow modern hunks to be stored deflated
Summary

Ref T4045. Ref T5179. When saving a modern hunk, deflate it if we have the function and deflating it will save a nontrivial number of bytes.

Test Plan
  • Used bin/hunks migrate to move some hunks over, saw ~70-80% compression on most standard hunks.
  • Viewed changesets using compressed hunks.
  • Profiled gzinflate() and verified the cost is trivial (<< 1ms) at least for normal diffs.

Diff Detail

Repository
rP Phabricator
Branch
hunk7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 702
Build 702: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22059.May 25 2014, 6:50 PM
epriestley retitled this revision from to Allow modern hunks to be stored deflated.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T5179: Unearth Differential rendering technical debt, T4045: Store diffs as binary, not UTF-8.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 25 2014, 6:50 PM
Harbormaster completed remote builds in B702: Diff 22059.May 25 2014, 6:51 PM
btrahan accepted this revision.Jun 3 2014, 10:12 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 3 2014, 10:12 PM
epriestley closed this revision.Jun 4 2014, 1:03 AM
epriestley updated this revision to Diff 22331.

Closed by commit rP4b39fbe1155e (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
cache/
61 lines
23 lines
differential/
management/
14 lines
storage/
78 lines

Diff 22059

View Options

src/applications/cache/PhabricatorCaches.php

Loading...
View Options

src/applications/cache/PhabricatorKeyValueDatabaseCache.php

Loading...
View Options

src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php

Loading...
View Options

src/applications/differential/storage/DifferentialHunkModern.php

Loading...
Phabricator · Built by Phacility