set custom arcrc file earlier
ClosedPublic
Actions

Authored by epriestley on May 22 2014, 10:59 PM.

Details

Reviewers

avivey

Commits

rARC0d0b8abcdd71: set custom arcrc file earlier

Summary

It appears to have never really work? At least as far as phabricator.uri (empirically).

Test Plan

removed ~/.arcrc, run call-conduit user.whoami with --arcrc-file and --trace.
set-config, get-config and alias also read and write to the right place now.

Diff Detail

Repository

rARC Arcanist

Branch

cache

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 676
Build 676: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 21999.May 22 2014, 10:59 PM

avivey retitled this revision from to set custom arcrc file earlier.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 22 2014, 10:59 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B660: Diff 21999.May 22 2014, 11:01 PM

Is it possible you updated, picked up rARC85b6c58, and that fixed it? I don't immediately see why this would fix anything...

No...

With this change (And no ~/.arcrc):

avive@vm:~/tmp$ echo {} | arc --trace  --arcrc-file=./jenkins-arcrc  call-conduit user.whoami
libphutil loaded from '/home/avive/devtools/libphutil/src'.
arcanist loaded from '/home/avive/devtools/arcanist/src'.
Config: Reading user configuration file "./jenkins-arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: No candidate locations for .arcconfig from this working directory.
Working Copy: Path "/tmp" is not in any working copy.
>>> [0] <conduit> conduit.connect() <bytes = 507>
>>> [1] <http> http://phabricator-app1-uat.snc1/api/conduit.connect
<<< [1] <http> 178,642 us
<<< [0] <conduit> 178,990 us
Waiting for JSON parameters on stdin...
>>> [2] <conduit> user.whoami() <bytes = 159>
>>> [3] <http> http://phabricator-app1-uat.snc1/api/user.whoami
<<< [3] <http> 167,431 us
<<< [2] <conduit> 167,734 us
{"error":null,"errorMessage":null,"response":{"userName":"Jenkins",......

reset arcanist to f64dee0

avive@vm:~/tmp$ echo {} | arc --trace  --arcrc-file=./jenkins-arcrc  call-conduit user.whoami
libphutil loaded from '/home/avive/devtools/libphutil/src'.
arcanist loaded from '/home/avive/devtools/arcanist/src'.
Config: Did not find user configuration at "/home/avive/.arcrc".
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: No candidate locations for .arcconfig from this working directory.
Working Copy: Path "/tmp" is not in any working copy.
Usage Exception: This command requires arc to connect to a Phabricator install, but no
Phabricator installation is configured. To configure a Phabricator URI:

  - set a default location with `arc set-config default <uri>`; or
  - specify '--conduit-uri=uri' explicitly; or
  - run 'arc' in a working copy with an '.arcconfig'.


[2014-05-22 23:09:34] EXCEPTION: (ArcanistUsageException) This command requires arc to connect to a Phabricator install, but no
Phabricator installation is configured. To configure a Phabricator URI:

  - set a default location with `arc set-config default <uri>`; or
  - specify '--conduit-uri=uri' explicitly; or
  - run 'arc' in a working copy with an '.arcconfig'.
 at [/home/avive/devtools/arcanist/scripts/arcanist.php:253]

I'm not exactly sure what's going on. The code doesn't look like this should change anything.

Oh, 104219d added caching. Let me fix that...

Also make the cache per-path.

Harbormaster completed remote builds in B661: Diff 22000.May 22 2014, 11:24 PM

avivey added inline comments.May 22 2014, 11:24 PM

scripts/arcanist.php
133–137	This is changed in any case (global_config is arcrc here). I never used it, but I think it's better to load from the provided arcrc than from the user's home.