Ref T3820. This doesn't actually do anything yet, but dumps in all the plumbing.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T8377: Build the core "Spaces" Application
T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects - Commits
- Restricted Diffusion Commit
rP541b4c86b405: Add "Spaces", an application for managing policy namespaces
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- spaces1
- Lint
Lint Passed Severity Location Code Message Advice src/applications/spaces/application/PhabricatorApplicationSpaces.php:34 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 581 Build 581: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Modernize, mostly trivial changes:
- Use modern $COLLATE patches.
- Use handleRequest().
- Remove device hint for pages.
- Use buildTransactionTimeline().
- Use validateIsEmptyTextField().
- Fix a weird regex in PHIDType.
- Use 1 and null more consistently as the available values for TYPE_DEFAULT.
- Add CONFIG_COLUMN_SCHEMA.
- Add CONFIG_KEY_SCHEMA.
- Remove getCapabilityKey() from custom capabilities.
- Add Application->getName().
- Implement getApplicationClassName() and getResultTypeDescription() on SearchEngine.
- Rename PHIDTypeNamespace to NamespacePHIDType.
- Remove getTypeConstant() from PHIDType.
- Add getEditorApplicationClass and getEditorObjectsDescription to Editor.
- Implement PhabricatorApplicationTransactionInterface on Namespace.
- Picked an icon.
Retested:
- Ran bin/storage upgrade -f, clean patches + no adjustments.
- Created a new namespace (it became the default space).
- Created another namespace (it became a non-default space).
- Made a few edits.
- Fiddled with default policies.
- Tried to create a Space with "can create" set to "no one"; blocked with policy exception.