To get there, upgrade "headerless" to "headerMode". Add a new removepanel controller. Fixes T5084.
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T5078: Clean up UltraDash++
T5084: Allow panels to be removed from a dashboard - Commits
- Restricted Diffusion Commit
rPd9058d7f3ff7: Dashboards - add remove functionality
removed some panels to much success
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T5084
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 578 Build 578: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Works but should re-factor.
| src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php | ||
|---|---|---|
| 109 | On second thought, I should do the opposite and put all this rendering code in here | |
Comment Actions
Cool, this looks good.
(One thing that might happens soon is letting PanelType add some icons to the header in "normal" mode, but we can address that in a variety of ways without changes here, and I think this is probably a cleaner architecture overall.)
| src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php | ||
|---|---|---|
| 88 | (Unused, I think, per other comment.) | |
| 112 | this miiiight be testing code | |
| src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php | ||
| 5–14 | Are these ever used? | |
Comment Actions
- remove test code
- remove un-used getter / setter
- re-direct back to "arrange" view on panel edit if you cancel or submit the edit for super fast workfly happy action times