D9156.id21749.diff
No OneTemporary
Actions

Size

23 KB

Referenced Files

None

Subscribers

None

D9156.id21749.diff
View Options

	diff --git a/resources/celerity/map.php b/resources/celerity/map.php
	--- a/resources/celerity/map.php
	+++ b/resources/celerity/map.php
	@@ -52,7 +52,7 @@
	'rsrc/css/application/conpherence/widget-pane.css' => 'bf275a6c',
	'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4',
	'rsrc/css/application/countdown/timer.css' => '86b7b0a0',
	- 'rsrc/css/application/dashboard/dashboard.css' => '2b41640b',
	+ 'rsrc/css/application/dashboard/dashboard.css' => '18da7822',
	'rsrc/css/application/diff/inline-comment-summary.css' => '8cfd34e8',
	'rsrc/css/application/differential/add-comment.css' => 'c478bcaa',
	'rsrc/css/application/differential/changeset-view.css' => '1570a1ff',
	@@ -358,7 +358,7 @@
	'rsrc/js/application/conpherence/behavior-pontificate.js' => '53f6f2dd',
	'rsrc/js/application/conpherence/behavior-widget-pane.js' => '40b1ff90',
	'rsrc/js/application/countdown/timer.js' => '889c96f3',
	- 'rsrc/js/application/dashboard/behavior-dashboard-async-panel.js' => 'f1375ea5',
	+ 'rsrc/js/application/dashboard/behavior-dashboard-async-panel.js' => '469c0d9e',
	'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => 'fa187a68',
	'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => 'f2441746',
	'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => '533a187b',
	@@ -553,7 +553,7 @@
	'javelin-behavior-conpherence-widget-pane' => '40b1ff90',
	'javelin-behavior-countdown-timer' => '889c96f3',
	'javelin-behavior-dark-console' => 'e9fdb5e5',
	- 'javelin-behavior-dashboard-async-panel' => 'f1375ea5',
	+ 'javelin-behavior-dashboard-async-panel' => '469c0d9e',
	'javelin-behavior-dashboard-move-panels' => 'fa187a68',
	'javelin-behavior-device' => '03d6ed07',
	'javelin-behavior-differential-add-reviewers-and-ccs' => '533a187b',
	@@ -701,7 +701,7 @@
	'phabricator-core-css' => '40151074',
	'phabricator-countdown-css' => '86b7b0a0',
	'phabricator-crumbs-view-css' => '6a23399c',
	- 'phabricator-dashboard-css' => '2b41640b',
	+ 'phabricator-dashboard-css' => '18da7822',
	'phabricator-drag-and-drop-file-upload' => 'ae6abfba',
	'phabricator-draggable-list' => '1681c4d4',
	'phabricator-fatal-config-template-css' => '25d446d6',
	@@ -1139,6 +1139,12 @@
	1 => 'javelin-stratcom',
	2 => 'javelin-dom',
	),
	+ '469c0d9e' =>
	+ array(
	+ 0 => 'javelin-behavior',
	+ 1 => 'javelin-dom',
	+ 2 => 'javelin-workflow',
	+ ),
	'46efd18e' =>
	array(
	0 => 'multirow-row-manager',
	@@ -1264,6 +1270,11 @@
	2 => 'javelin-util',
	3 => 'phabricator-shaped-request',
	),
	+ '7319e029' =>
	+ array(
	+ 0 => 'javelin-behavior',
	+ 1 => 'javelin-dom',
	+ ),
	'62e18640' =>
	array(
	0 => 'javelin-install',
	@@ -1318,11 +1329,6 @@
	1 => 'javelin-stratcom',
	2 => 'javelin-dom',
	),
	- '7319e029' =>
	- array(
	- 0 => 'javelin-behavior',
	- 1 => 'javelin-dom',
	- ),
	'76f4ebed' =>
	array(
	0 => 'javelin-install',
	@@ -1965,12 +1971,6 @@
	0 => 'javelin-install',
	1 => 'javelin-util',
	),
	- 'f1375ea5' =>
	- array(
	- 0 => 'javelin-behavior',
	- 1 => 'javelin-dom',
	- 2 => 'javelin-workflow',
	- ),
	'f2441746' =>
	array(
	0 => 'javelin-dom',
	diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
	--- a/src/__phutil_library_map__.php
	+++ b/src/__phutil_library_map__.php
	@@ -1485,6 +1485,7 @@
	'PhabricatorDashboardPanelTypeText' => 'applications/dashboard/paneltype/PhabricatorDashboardPanelTypeText.php',
	'PhabricatorDashboardPanelViewController' => 'applications/dashboard/controller/PhabricatorDashboardPanelViewController.php',
	'PhabricatorDashboardQuery' => 'applications/dashboard/query/PhabricatorDashboardQuery.php',
	+ 'PhabricatorDashboardRemovePanelController' => 'applications/dashboard/controller/PhabricatorDashboardRemovePanelController.php',
	'PhabricatorDashboardRenderingEngine' => 'applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php',
	'PhabricatorDashboardSearchEngine' => 'applications/dashboard/query/PhabricatorDashboardSearchEngine.php',
	'PhabricatorDashboardTransaction' => 'applications/dashboard/storage/PhabricatorDashboardTransaction.php',
	@@ -4273,6 +4274,7 @@
	'PhabricatorDashboardPanelTypeText' => 'PhabricatorDashboardPanelType',
	'PhabricatorDashboardPanelViewController' => 'PhabricatorDashboardController',
	'PhabricatorDashboardQuery' => 'PhabricatorCursorPagedPolicyAwareQuery',
	+ 'PhabricatorDashboardRemovePanelController' => 'PhabricatorDashboardController',
	'PhabricatorDashboardRenderingEngine' => 'Phobject',
	'PhabricatorDashboardSearchEngine' => 'PhabricatorApplicationSearchEngine',
	'PhabricatorDashboardTransaction' => 'PhabricatorApplicationTransaction',
	diff --git a/src/applications/dashboard/application/PhabricatorApplicationDashboard.php b/src/applications/dashboard/application/PhabricatorApplicationDashboard.php
	--- a/src/applications/dashboard/application/PhabricatorApplicationDashboard.php
	+++ b/src/applications/dashboard/application/PhabricatorApplicationDashboard.php
	@@ -26,6 +26,8 @@
	'edit/(?:(?P<id>\d+)/)?' => 'PhabricatorDashboardEditController',
	'addpanel/(?P<id>\d+)/' => 'PhabricatorDashboardAddPanelController',
	'movepanel/(?P<id>\d+)/' => 'PhabricatorDashboardMovePanelController',
	+ 'removepanel/(?P<id>\d+)/'
	+ => 'PhabricatorDashboardRemovePanelController',
	'panel/' => array(
	'(?:query/(?P<queryKey>[^/]+)/)?'
	=> 'PhabricatorDashboardPanelListController',
	diff --git a/src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php b/src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
	--- a/src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
	+++ b/src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php
	@@ -68,12 +68,10 @@
	),
	));

	- if ($layout_config->isMultiColumnLayout()) {
	- $layout_config->setPanelLocation(
	- $request->getInt('column'),
	- $panel->getPHID());
	- $dashboard->setLayoutConfigFromObject($layout_config);
	- }
	+ $layout_config->setPanelLocation(
	+ $request->getInt('column', 0),
	+ $panel->getPHID());
	+ $dashboard->setLayoutConfigFromObject($layout_config);

	$editor = id(new PhabricatorDashboardTransactionEditor())
	->setActor($viewer)
	diff --git a/src/applications/dashboard/controller/PhabricatorDashboardMovePanelController.php b/src/applications/dashboard/controller/PhabricatorDashboardMovePanelController.php
	--- a/src/applications/dashboard/controller/PhabricatorDashboardMovePanelController.php
	+++ b/src/applications/dashboard/controller/PhabricatorDashboardMovePanelController.php
	@@ -38,21 +38,9 @@
	}

	$layout_config = $dashboard->getLayoutConfigObject();
	+ $layout_config->removePanel($panel_phid);
	$panel_location_grid = $layout_config->getPanelLocations();

	- foreach ($panel_location_grid as $column => $panel_columns) {
	- $found_old_column = array_search($panel_phid, $panel_columns);
	- if ($found_old_column !== false) {
	- $new_panel_columns = $panel_columns;
	- array_splice(
	- $new_panel_columns,
	- $found_old_column,
	- 1,
	- array());
	- $panel_location_grid[$column] = $new_panel_columns;
	- break;
	- }
	- }
	$panel_columns = idx($panel_location_grid, $column_id, array());
	if ($panel_columns) {
	$insert_at = 0;
	diff --git a/src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php b/src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php
	--- a/src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php
	+++ b/src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php
	@@ -37,7 +37,8 @@
	->setViewer($viewer)
	->setPanel($panel)
	->setParentPanelPHIDs($parent_phids)
	- ->setHeaderless($request->getBool('headerless'))
	+ ->setHeaderMode($request->getStr('headerMode'))
	+ ->setDashboardID($request->getInt('dashboardID'))
	->renderPanel();

	if ($request->isAjax()) {
	diff --git a/src/applications/dashboard/controller/PhabricatorDashboardRemovePanelController.php b/src/applications/dashboard/controller/PhabricatorDashboardRemovePanelController.php
	new file mode 100644
	--- /dev/null
	+++ b/src/applications/dashboard/controller/PhabricatorDashboardRemovePanelController.php
	@@ -0,0 +1,82 @@
	+<?php
	+
	+final class PhabricatorDashboardRemovePanelController
	+ extends PhabricatorDashboardController {
	+
	+ private $id;
	+
	+ public function willProcessRequest(array $data) {
	+ $this->id = idx($data, 'id');
	+ }
	+
	+ public function processRequest() {
	+ $request = $this->getRequest();
	+ $viewer = $request->getUser();
	+
	+ $dashboard = id(new PhabricatorDashboardQuery())
	+ ->setViewer($viewer)
	+ ->withIDs(array($this->id))
	+ ->requireCapabilities(
	+ array(
	+ PhabricatorPolicyCapability::CAN_VIEW,
	+ PhabricatorPolicyCapability::CAN_EDIT,
	+ ))
	+ ->executeOne();
	+ if (!$dashboard) {
	+ return new Aphront404Response();
	+ }
	+
	+ $v_panel = $request->getStr('panelPHID');
	+ $panel = id(new PhabricatorDashboardPanelQuery())
	+ ->setViewer($viewer)
	+ ->withPHIDs(array($v_panel))
	+ ->executeOne();
	+ if (!$panel) {
	+ return new Aphront404Response();
	+ }
	+
	+ $redirect_uri = $this->getApplicationURI(
	+ 'arrange/'.$dashboard->getID().'/');
	+ $layout_config = $dashboard->getLayoutConfigObject();
	+
	+ if ($request->isFormPost()) {
	+ $xactions = array();
	+ $xactions[] = id(new PhabricatorDashboardTransaction())
	+ ->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
	+ ->setMetadataValue(
	+ 'edge:type',
	+ PhabricatorEdgeConfig::TYPE_DASHBOARD_HAS_PANEL)
	+ ->setNewValue(
	+ array(
	+ '-' => array(
	+ $panel->getPHID() => $panel->getPHID(),
	+ ),
	+ ));
	+
	+ $layout_config->removePanel($panel->getPHID());
	+ $dashboard->setLayoutConfigFromObject($layout_config);
	+
	+ $editor = id(new PhabricatorDashboardTransactionEditor())
	+ ->setActor($viewer)
	+ ->setContentSourceFromRequest($request)
	+ ->setContinueOnMissingFields(true)
	+ ->setContinueOnNoEffect(true)
	+ ->applyTransactions($dashboard, $xactions);
	+
	+ return id(new AphrontRedirectResponse())->setURI($redirect_uri);
	+ }
	+
	+ $form = id(new AphrontFormView())
	+ ->setUser($viewer)
	+ ->addHiddenInput('confirm', true)
	+ ->addHiddenInput('panelPHID', $v_panel)
	+ ->appendChild(pht('Are you sure you want to remove this panel?'));
	+
	+ return $this->newDialog()
	+ ->setTitle(pht('Remove Panel %s', $panel->getMonogram()))
	+ ->appendChild($form->buildLayoutView())
	+ ->addCancelButton($redirect_uri)
	+ ->addSubmitButton(pht('Remove Panel'));
	+ }
	+
	+}
	diff --git a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
	--- a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
	+++ b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
	@@ -2,19 +2,33 @@

	final class PhabricatorDashboardPanelRenderingEngine extends Phobject {

	+ const HEADER_MODE_NORMAL = 'normal';
	+ const HEADER_MODE_NONE = 'none';
	+ const HEADER_MODE_EDIT = 'edit';
	+
	private $panel;
	private $viewer;
	private $enableAsyncRendering;
	private $parentPanelPHIDs;
	- private $headerless;
	+ private $headerMode = self::HEADER_MODE_NORMAL;
	+ private $dashboardID;

	- public function setHeaderless($headerless) {
	- $this->headerless = $headerless;
	+ public function setDashboardID($id) {
	+ $this->dashboardID = $id;
	return $this;
	}

	- public function getHeaderless() {
	- return $this->headerless;
	+ public function getDashboardID() {
	+ return $this->dashboardID;
	+ }
	+
	+ public function setHeaderMode($header_mode) {
	+ $this->headerMode = $header_mode;
	+ return $this;
	+ }
	+
	+ public function getHeaderMode() {
	+ return $this->headerMode;
	}

	/**
	@@ -63,13 +77,14 @@
	'Phabricator.',
	$panel->getPanelType()));
	}
	+ $panel_type->setDashboardID($this->getDashboardID());

	try {
	$this->detectRenderingCycle($panel);

	if ($this->enableAsyncRendering) {
	if ($panel_type->shouldRenderAsync()) {
	- return $this->renderAsyncPanel($panel);
	+ return $panel_type->renderAsyncPanel($viewer, $panel, $this);
	}
	}

	@@ -84,47 +99,22 @@
	}
	}

	+ // TODO - this should move to PhabricatorDashboardPanelType
	private function renderErrorPanel($title, $body) {
	- if ($this->getHeaderless()) {
	- return id(new AphrontErrorView())
	- ->setErrors(array($body));
	- } else {
	- return id(new PHUIObjectBoxView())
	- ->setHeaderText($title)
	- ->setFormErrors(array($body));
	- }
	- }
	-
	- private function renderAsyncPanel(PhabricatorDashboardPanel $panel) {
	- $panel_id = celerity_generate_unique_node_id();
	-
	- Javelin::initBehavior(
	- 'dashboard-async-panel',
	- array(
	- 'panelID' => $panel_id,
	- 'parentPanelPHIDs' => $this->getParentPanelPHIDs(),
	- 'headerless' => $this->getHeaderless(),
	- 'uri' => '/dashboard/panel/render/'.$panel->getID().'/',
	- ));
	-
	- $content = pht('Loading...');
	-
	- if ($this->headerless) {
	- return phutil_tag(
	- 'div',
	- array(
	- 'id' => $panel_id,
	- ),
	- $content);
	- } else {
	- return id(new PHUIObjectBoxView())
	- ->addSigil('dashboard-panel')
	- ->setMetadata(array(
	- 'objectPHID' => $panel->getPHID()))
	- ->setHeaderText($panel->getName())
	- ->setID($panel_id)
	- ->appendChild($content);
	+ switch ($this->getHeaderMode()) {
	+ case self::HEADER_MODE_NONE:
	+ $panel = id(new AphrontErrorView())
	+ ->setErrors(array($body));
	+ break;
	+ case self::HEADER_MODE_NORMAL:
	+ case self::HEADER_MODE_EDIT:
	+ default:
	+ $panel = id(new PHUIObjectBoxView())
	+ ->setHeaderText($title)
	+ ->setFormErrors(array($body));
	+ break;
	}
	+ return $panel;
	}

	/**
	diff --git a/src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php b/src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php
	--- a/src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php
	+++ b/src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php
	@@ -34,6 +34,11 @@
	->setID($dashboard_id)
	->setFluidlayout(true);

	+ if ($this->arrangeMode) {
	+ $h_mode = PhabricatorDashboardPanelRenderingEngine::HEADER_MODE_EDIT;
	+ } else {
	+ $h_mode = PhabricatorDashboardPanelRenderingEngine::HEADER_MODE_NORMAL;
	+ }
	foreach ($panel_grid_locations as $column => $panel_column_locations) {
	$panel_phids = $panel_column_locations;
	$column_panels = array_select_keys($panels, $panel_phids);
	@@ -42,8 +47,10 @@
	$column_result[] = id(new PhabricatorDashboardPanelRenderingEngine())
	->setViewer($viewer)
	->setPanel($panel)
	+ ->setDashboardID($dashboard->getID())
	->setEnableAsyncRendering(true)
	->setParentPanelPHIDs(array())
	+ ->setHeaderMode($h_mode)
	->renderPanel();
	}
	$column_class = $layout_config->getColumnClass(
	diff --git a/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php b/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php
	--- a/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php
	+++ b/src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php
	@@ -32,6 +32,24 @@
	return $this->panelLocations;
	}

	+ public function removePanel($panel_phid) {
	+ $panel_location_grid = $this->getPanelLocations();
	+ foreach ($panel_location_grid as $column => $panel_columns) {
	+ $found_old_column = array_search($panel_phid, $panel_columns);
	+ if ($found_old_column !== false) {
	+ $new_panel_columns = $panel_columns;
	+ array_splice(
	+ $new_panel_columns,
	+ $found_old_column,
	+ 1,
	+ array());
	+ $panel_location_grid[$column] = $new_panel_columns;
	+ break;
	+ }
	+ }
	+ $this->setPanelLocations($panel_location_grid);
	+ }
	+
	public function getDefaultPanelLocations() {
	switch ($this->getLayoutMode()) {
	case self::MODE_HALF_AND_HALF:
	diff --git a/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php b/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php
	--- a/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php
	+++ b/src/applications/dashboard/paneltype/PhabricatorDashboardPanelType.php
	@@ -2,6 +2,17 @@

	abstract class PhabricatorDashboardPanelType extends Phobject {

	+ private $dashboardID;
	+
	+ public function setDashboardID($id) {
	+ $this->dashboardID = $id;
	+ return $this;
	+ }
	+
	+ public function getDashboardID() {
	+ return $this->dashboardID;
	+ }
	+
	abstract public function getPanelTypeKey();
	abstract public function getPanelTypeName();
	abstract public function getPanelTypeDescription();
	@@ -46,17 +57,104 @@
	PhabricatorDashboardPanelRenderingEngine $engine) {

	$content = $this->renderPanelContent($viewer, $panel, $engine);
	+ $header = $this->renderPanelHeader($viewer, $panel, $engine);
	+
	+ return $this->renderPanelDiv(
	+ $panel,
	+ $content,
	+ $header);
	+ }

	- if ($engine->getHeaderless()) {
	- return $content;
	+ private function renderPanelHeader(
	+ PhabricatorUser $viewer,
	+ PhabricatorDashboardPanel $panel,
	+ PhabricatorDashboardPanelRenderingEngine $engine) {
	+
	+ switch ($engine->getHeaderMode()) {
	+ case PhabricatorDashboardPanelRenderingEngine::HEADER_MODE_NONE:
	+ $header = null;
	+ break;
	+ case PhabricatorDashboardPanelRenderingEngine::HEADER_MODE_EDIT:
	+ $action_edit = id(new PHUIIconView())
	+ ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
	+ ->setSpriteIcon('settings-grey')
	+ ->setHref('/dashboard/panel/edit/'.$panel->getID().'/');
	+ $header = id(new PhabricatorActionHeaderView())
	+ ->setHeaderTitle($panel->getName())
	+ ->setHeaderColor(PhabricatorActionHeaderView::HEADER_GREY)
	+ ->addAction($action_edit);
	+ $dashboard_id = $this->getDashboardID();
	+ if ($dashboard_id) {
	+ $uri = id(new PhutilURI(
	+ '/dashboard/removepanel/'.$dashboard_id.'/'))
	+ ->setQueryParam('panelPHID', $panel->getPHID());
	+ $action_remove = id(new PHUIIconView())
	+ ->setSpriteSheet(PHUIIconView::SPRITE_ACTIONS)
	+ ->setSpriteIcon('close-grey')
	+ ->setHref((string) $uri)
	+ ->setWorkflow(true);
	+ $header->addAction($action_remove);
	+ }
	+ break;
	+ case PhabricatorDashboardPanelRenderingEngine::HEADER_MODE_NORMAL:
	+ default:
	+ $header = id(new PhabricatorActionHeaderView())
	+ ->setHeaderTitle($panel->getName())
	+ ->setHeaderColor(PhabricatorActionHeaderView::HEADER_GREY);
	+ break;
	}
	+ return $header;
	+ }
	+
	+ private function renderPanelDiv(
	+ PhabricatorDashboardPanel $panel,
	+ $content,
	+ $header = null,
	+ $id = null) {
	+
	+ if (!$id) {
	+ $id = celerity_generate_unique_node_id();
	+ }
	+ return javelin_tag(
	+ 'div',
	+ array(
	+ 'id' => $id,
	+ 'sigil' => 'dashboard-panel',
	+ 'meta' => array(
	+ 'objectPHID' => $panel->getPHID()),
	+ 'class' => 'dashboard-panel'),
	+ array(
	+ $header,
	+ $content));
	+ }
	+
	+ public function renderAsyncPanel(
	+ PhabricatorUser $viewer,
	+ PhabricatorDashboardPanel $panel,
	+ PhabricatorDashboardPanelRenderingEngine $engine) {
	+
	+ $panel_id = celerity_generate_unique_node_id();
	+ $dashboard_id = $this->getDashboardID();
	+
	+ Javelin::initBehavior(
	+ 'dashboard-async-panel',
	+ array(
	+ 'panelID' => $panel_id,
	+ 'parentPanelPHIDs' => $engine->getParentPanelPHIDs(),
	+ 'headerMode' => $engine->getHeaderMode(),
	+ 'dashboardID' => $dashboard_id,
	+ 'uri' => '/dashboard/panel/render/'.$panel->getID().'/',
	+ ));
	+
	+ $header = $this->renderPanelHeader($viewer, $panel, $engine);
	+ $content = id(new PHUIPropertyListView())
	+ ->addTextContent(pht('Loading...'));

	- return id(new PHUIObjectBoxView())
	- ->addSigil('dashboard-panel')
	- ->setMetadata(array(
	- 'objectPHID' => $panel->getPHID()))
	- ->setHeaderText($panel->getName())
	- ->appendChild($content);
	+ return $this->renderPanelDiv(
	+ $panel,
	+ $content,
	+ $header,
	+ $panel_id);
	}

	protected function renderPanelContent(
	diff --git a/src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php b/src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php
	--- a/src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php
	+++ b/src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php
	@@ -81,6 +81,7 @@
	$parent_phids[] = $panel->getPHID();

	$content = array();
	+ $no_headers = PhabricatorDashboardPanelRenderingEngine::HEADER_MODE_NONE;
	foreach ($config as $idx => $tab_spec) {
	$panel_id = idx($tab_spec, 'panelID');
	$panel = idx($panels, $panel_id);
	@@ -91,7 +92,7 @@
	->setEnableAsyncRendering(true)
	->setParentPanelPHIDs($parent_phids)
	->setPanel($panel)
	- ->setHeaderless(true)
	+ ->setHeaderMode($no_headers)
	->renderPanel();
	} else {
	$panel_content = pht('(Invalid Panel)');
	diff --git a/webroot/rsrc/css/application/dashboard/dashboard.css b/webroot/rsrc/css/application/dashboard/dashboard.css
	--- a/webroot/rsrc/css/application/dashboard/dashboard.css
	+++ b/webroot/rsrc/css/application/dashboard/dashboard.css
	@@ -18,8 +18,14 @@
	}

	.aphront-multi-column-fluid
	+.aphront-multi-column-column-outer
	+.aphront-multi-column-column .dashboard-panel {
	+ margin: 16px 16px 0px 16px;
	+}
	+
	+.aphront-multi-column-fluid
	.aphront-multi-column-column-outer.grippable
	-.aphront-multi-column-column .phui-object-box {
	+.aphront-multi-column-column .dashboard-panel {
	cursor: move;
	}

	diff --git a/webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js b/webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js
	--- a/webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js
	+++ b/webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js
	@@ -11,7 +11,8 @@

	var data = {
	parentPanelPHIDs: config.parentPanelPHIDs.join(','),
	- headerless: config.headerless ? 1 : 0
	+ headerMode: config.headerMode,
	+ dashboardID: config.dashboardID
	};

	new JX.Workflow(config.uri)

File Metadata

Mime Type: text/plain
Expires: Mon, Mar 10, 10:45 PM (1 w, 5 d ago)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 7477667
Default Alt Text: D9156.id21749.diff (23 KB)

D9156.id21749.diffNo OneTemporaryActions

D9156.id21749.diffView Options

File Metadata

Event Timeline

D9156.id21749.diff
No OneTemporary
Actions

D9156.id21749.diff
View Options