Page MenuHomePhabricator

Improve autofixing of double quotes in XHPAST linter.
ClosedPublic

Authored by joshuaspence on May 19 2014, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 4:06 AM
Unknown Object (File)
Mon, Dec 16, 11:18 PM
Unknown Object (File)
Sun, Dec 15, 7:27 AM
Unknown Object (File)
Wed, Dec 4, 10:37 PM
Unknown Object (File)
Nov 30 2024, 2:57 PM
Unknown Object (File)
Nov 27 2024, 7:05 AM
Unknown Object (File)
Nov 24 2024, 4:26 PM
Unknown Object (File)
Nov 23 2024, 9:31 AM
Subscribers

Details

Summary

The XHPAST double quotes rule autofixes strings which use double quotes where single quotes would suffice. In the case in which the double-quoted string contained an escaped double quote, the autofix string can be improved by removing the escape symbol.

Test Plan

Modified existing unit tests to cover this case.

Diff Detail

Repository
rARC Arcanist
Branch
xhpast-double_quotes
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 569
Build 569: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve autofixing of double quotes in XHPAST linter..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 2:49 PM
epriestley updated this revision to Diff 21841.

Closed by commit rARC1b0ab48f15d4 (authored by @joshuaspence, committed by @epriestley).