Relax the version regex for `ArcanistFlake8Linter`.
ClosedPublic
Actions

Authored by joshuaspence on May 18 2014, 1:16 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCb4b6a33d2a8d: Relax the version regex for `ArcanistFlake8Linter`.

Summary

As noticed by @epriestley in D9060, flake8 --version can emit a string like "2.0" rather than the expected "2.0.0".

Test Plan

Uninstalled my existing version of flake8 (v2.1.0) and installed a prior version (pip install flake8==2.0.0). Ran flake8 --version and inspected the output.

Diff Detail

Repository

rARC Arcanist

Branch

flake8-verison

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 540
Build 540: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21789.May 18 2014, 1:16 AM

joshuaspence retitled this revision from to Relax the version regex for `ArcanistFlake8Linter`..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a subscriber: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 18 2014, 1:16 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Harbormaster completed remote builds in B540: Diff 21789.May 18 2014, 1:17 AM

Closed by commit rARCb4b6a33d2a8d (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistFlake8Linter.php

2 lines

Diff 21789

View Options

src/lint/linter/ArcanistFlake8Linter.php

Relax the version regex for `ArcanistFlake8Linter`.ClosedPublicActions