Specify minimum versions for linters in lint unit tests
Needs RevisionPublic
Actions

Authored by epriestley on May 12 2014, 12:19 AM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

Summary

Ref T2039. Some of the tests don't pass on older linters. Allow tests to specify a minimum external linter version.

Also fix two minor issues:

Test Plan

Ran arc unit, got skips, updated, got passing tests. See tests on this diff.

Repository

rARC Arcanist

Branch

uminversion

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 373
Build 373: [Placeholder Plan] Wait for 30 Seconds

epriestley retitled this revision from to Specify minimum versions for linters in lint unit tests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a task: Restricted Maniphest Task.

I think a bit more work is required here.

src/lint/linter/__tests__/ArcanistLinterTestCase.php
11	Originally, I thought that we may want to specify the minimum version on a per-test-case basis. If we just skip all of the tests based on the version number, then it's hard to tell what the minimum version (of the external linter) that we support is.
117	I think that the `version_compare` logic should exist in the `ArcanistLinter` class itself. By default we can use `version_compare`, however for some linters we may need to provide some custom/additional logic. Also, for some linters it doesn't even make sense to compare version numbers (because there are none).