Fix "arc diff --raw-command --create"
ClosedPublic
Actions

Authored by epriestley on May 17 2014, 7:47 PM.

Tags

None

Referenced Files

	F15461389: D9165.id.diff
	Tue, Apr 1, 7:59 AM

	F15449796: D9165.id21776.diff
	Fri, Mar 28, 12:20 PM

	F15434590: D9165.diff
	Tue, Mar 25, 4:34 AM

	F15427000: D9165.id21776.diff
	Sun, Mar 23, 12:12 PM

	F15426130: D9165.id21776.diff
	Sun, Mar 23, 7:21 AM

	F15407822: D9165.id21776.diff
	Tue, Mar 18, 7:51 PM

	F15406381: D9165.diff
	Tue, Mar 18, 12:29 PM

	F15403025: D9165.id21776.diff
	Tue, Mar 18, 1:41 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T5082: arc diff --raw-command --create does not work

Commits

rARCb52f3fafe3ae: Fix "arc diff --raw-command --create"

Summary

Fixes T5082. We try to access the repository API in some cases when we don't have one.

Test Plan

Made revisions with "arc diff --raw-command --create".
Made this revision, without "--raw-command".

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21773.May 17 2014, 7:47 PM

epriestley retitled this revision from to Fix "arc diff --raw-command --create".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5082: arc diff --raw-command --create does not work.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 17 2014, 7:47 PM

Harbormaster completed remote builds in B530: Diff 21773.May 17 2014, 7:48 PM

btrahan accepted this revision.May 17 2014, 8:04 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 17 2014, 8:04 PM

Closed by commit rARCb52f3fafe3ae (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBaseWorkflow.php

8 lines

ArcanistDiffWorkflow.php

28 lines

Diff 21776

View Options

src/workflow/ArcanistBaseWorkflow.php