Differential D9165

Fix "arc diff --raw-command --create"
ClosedPublic
Actions

Authored by epriestley on May 17 2014, 7:47 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5082: arc diff --raw-command --create does not work

Commits

rARCb52f3fafe3ae: Fix "arc diff --raw-command --create"

Summary

Fixes T5082. We try to access the repository API in some cases when we don't have one.

Test Plan

Made revisions with "arc diff --raw-command --create".
Made this revision, without "--raw-command".

Diff Detail

Repository

rARC Arcanist

Branch

rawcmd

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 530
Build 530: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21773.May 17 2014, 7:47 PM

epriestley retitled this revision from to Fix "arc diff --raw-command --create".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5082: arc diff --raw-command --create does not work.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 17 2014, 7:47 PM

Harbormaster completed remote builds in B530: Diff 21773.May 17 2014, 7:48 PM

btrahan accepted this revision.May 17 2014, 8:04 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 17 2014, 8:04 PM

Closed by commit rARCb52f3fafe3ae (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBaseWorkflow.php

8 lines

ArcanistDiffWorkflow.php

28 lines

Diff 21773

View Options

src/workflow/ArcanistBaseWorkflow.php