Page MenuHomePhabricator
Differential D9160

Fix the `ArcanistJSONLintLinter::getVersion` function.
ClosedPublic
Actions

Authored by joshuaspence on May 17 2014, 11:51 AM.
Tags
None
Referenced Files
F13269435: D9160.diff
Wed, May 29, 6:20 AM
F13254834: D9160.diff
Sat, May 25, 3:48 AM
F13247205: D9160.id21768.diff
Thu, May 23, 4:42 PM
F13247063: D9160.id21792.diff
Thu, May 23, 3:31 PM
F13235154: D9160.diff
Tue, May 21, 4:18 AM
F13213999: D9160.diff
Fri, May 17, 8:22 AM
F13201355: D9160.id21768.diff
Tue, May 14, 11:14 AM
F13199189: D9160.diff
Mon, May 13, 12:42 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4954: Allow version dependencies to be specified for external linters
Commits
rARC4181fbde12a7: Fix the `ArcanistJSONLintLinter::getVersion` function.
Summary

Ref T4954. There was a typo in the original implementation. It wasn't noticed until now because the getVersion function isn't really used anywhere.

Test Plan

Ran arc linters in a repository with ArcanistJSONLintLinter configured, noticed that the version number appeared in the output.

Diff Detail

Repository
rARC Arcanist
Branch
jsonlint-version
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 525
Build 525: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21768.May 17 2014, 11:51 AM
joshuaspence retitled this revision from to Fix the `ArcanistJSONLintLinter::getVersion` function..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 17 2014, 11:51 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence updated this object.May 17 2014, 11:52 AM
joshuaspence edited edge metadata.
joshuaspence added a task: T4954: Allow version dependencies to be specified for external linters.
Harbormaster completed remote builds in B525: Diff 21768.May 17 2014, 11:52 AM
epriestley accepted this revision.May 18 2014, 1:36 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 18 2014, 1:36 AM
epriestley closed this revision.May 18 2014, 1:36 AM
epriestley updated this revision to Diff 21792.

Closed by commit rARC4181fbde12a7 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
2 lines

Diff 21768

View Options

src/lint/linter/ArcanistJSONLintLinter.php

Loading...
Phabricator · Built by Phacility