Page MenuHomePhabricator

Remove documentation about obsolete Differential event listeners
ClosedPublic

Authored by epriestley on May 16 2014, 11:48 AM.
Tags
None
Referenced Files
F14370241: D9151.diff
Fri, Dec 20, 5:45 PM
Unknown Object (File)
Thu, Dec 12, 4:28 AM
Unknown Object (File)
Thu, Dec 12, 4:28 AM
Unknown Object (File)
Thu, Dec 12, 4:07 AM
Unknown Object (File)
Thu, Dec 12, 3:43 AM
Unknown Object (File)
Mon, Dec 9, 11:14 PM
Unknown Object (File)
Fri, Dec 6, 12:07 PM
Unknown Object (File)
Sat, Nov 30, 6:51 PM
Subscribers

Details

Summary

Fixes T5069. T2222 mostly-intentionally stopped emitting these.

My sense is that users generally find event listeners (or, really, writing PHP at all) much less preferable to things like Herald rules or HTTP hooks. This is generally good, since those things are way easier to maintain, so I plan to continue moving away from events in cases where we have reasonable alternatives.

We also generally have more and better alternatives now than when these were written.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
docup
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 504
Build 504: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove documentation about obsolete Differential event listeners.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 16 2014, 3:25 PM
epriestley updated this revision to Diff 21737.

Closed by commit rP4925dd7e6eea (authored by @epriestley).