Page MenuHomePhabricator

Remove obsolete TYPE_DIFFERENTIAL_* event types from documentation (or re-introduce those events)
Closed, ResolvedPublic

Description

We have an event listener that listens to differential & maniphest edits and posts notifications to a HipChat room.

Recently, I updated phabricator and that event listener stopped working. After some digging, I found D8454, where TYPE_DIFFERENTIAL_WILLWRITEREVISION and TYPE_DIFFERENTIAL_DIDWRITEREVISION are removed. It also seems that TYPE_DIFFERENTIAL_WILLSENDMAIL was also removed elsewhere.

Re-introducing these event types would save me a little time, but I think we can probably utilize Herald to do what we need to do (or, even better, T1271).

Anyway, these event types are still present in PhabricatorEventType.php as well as https://secure.phabricator.com/book/phabricator/article/events/ - they should probably be removed since they are no longer dispatched.

Event Timeline

aripringle raised the priority of this task from to Needs Triage.
aripringle updated the task description. (Show Details)
aripringle added a subscriber: aripringle.

D9151 removes these from the documentation.

The best approaches for HipChat are probably polling feed.query (in Conduit) or using feed.http-hooks (in Config). In the longer term we'll support XMPP/Jabber on the bot, but this could be a while.

epriestley triaged this task as Normal priority.