Page MenuHomePhabricator
Differential D9119

Pass correct number of parameters to pht() when closing a branch in Mercurial
ClosedPublic
Actions

Authored by epriestley on May 14 2014, 3:49 PM.
Tags
None
Referenced Files
F19893525: D9119.diff
Sat, Mar 28, 7:34 AM
F19825160: D9119.id.diff
Mar 8 2026, 8:09 AM
F19769533: D9119.id21679.diff
Feb 19 2026, 8:16 PM
F19555692: D9119.diff
Jan 30 2026, 5:43 PM
F19096718: D9119.id.diff
Dec 4 2025, 10:42 AM
F19093648: D9119.diff
Dec 3 2025, 10:08 PM
F18939608: D9119.id21661.diff
Nov 11 2025, 7:01 AM
F18939607: D9119.id21679.diff
Nov 11 2025, 7:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5050: Cannot Push Branch Close Commits to Hosted Mercurial Repositories
Commits
Restricted Diffusion Commit
rPfe0c98faccbc: Pass correct number of parameters to pht() when closing a branch in Mercurial
Summary

Ref T5050. This fixes the immediate error (bad pht()) but doesn't fix the other error (can't --close-branch) yet.

Test Plan

Pushed a --close-branch commit, got a first-level error instead of an error about an error.

Diff Detail

Repository
rP Phabricator
Branch
hgerr
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/engine/DiffusionCommitHookEngine.php:740XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 460
Build 460: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 21661.May 14 2014, 3:49 PM
epriestley retitled this revision from to Pass correct number of parameters to pht() when closing a branch in Mercurial.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5050: Cannot Push Branch Close Commits to Hosted Mercurial Repositories.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 14 2014, 3:49 PM
Harbormaster completed remote builds in B460: Diff 21661.May 14 2014, 3:50 PM
btrahan accepted this revision.May 14 2014, 4:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 14 2014, 4:40 PM
epriestley closed this revision.May 14 2014, 11:59 PM
epriestley updated this revision to Diff 21679.

Closed by commit rPfe0c98faccbc (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
engine/
8 lines

Diff 21661

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
Phabricator · Built by Phacility