Ref T5050. This fixes the immediate error (bad pht()) but doesn't fix the other error (can't --close-branch) yet.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T5050: Cannot Push Branch Close Commits to Hosted Mercurial Repositories
- Commits
- Restricted Diffusion Commit
rPfe0c98faccbc: Pass correct number of parameters to pht() when closing a branch in Mercurial
Pushed a --close-branch commit, got a first-level error instead of an error about an error.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hgerr
- Lint
Lint Passed Severity Location Code Message Advice src/applications/diffusion/engine/DiffusionCommitHookEngine.php:740 XHP16 TODO Comment - Unit
No Test Coverage - Build Status
Buildable 460 Build 460: [Placeholder Plan] Wait for 30 Seconds