Page MenuHomePhabricator

Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class.
ClosedPublic

Authored by joshuaspence on May 14 2014, 4:16 AM.
Tags
None
Referenced Files
F14065105: D9114.diff
Tue, Nov 19, 3:01 AM
F14059579: D9114.diff
Sun, Nov 17, 8:34 PM
F14048415: D9114.diff
Thu, Nov 14, 7:42 AM
F14038688: D9114.diff
Mon, Nov 11, 1:20 AM
F14037107: D9114.diff
Sun, Nov 10, 1:53 PM
F14020597: D9114.diff
Wed, Nov 6, 12:54 AM
F13989895: D9114.diff
Mon, Oct 21, 11:44 PM
F13975689: D9114.diff
Oct 18 2024, 11:12 AM
Subscribers

Details

Summary

Since this method is only used within this class, it makes sense to move it here.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
lintengine-pep8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 454
Build 454: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.

D3882 explicitly moved this up after accept, but I don't know why. I assume it was just a generality thing since .arclint and similar were nowehere in sight.

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2014, 2:18 AM
epriestley updated this revision to Diff 21753.

Closed by commit rARC38eda3e86bb3 (authored by @joshuaspence, committed by @epriestley).