Paths

Table of Contentst

Differential D9114

Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class.
ClosedPublic
Actions

Authored by joshuaspence on May 14 2014, 4:16 AM.

Tags

None

Referenced Files

	F19005653: D9114.diff
	Nov 21 2025, 3:58 PM

	F18946630: D9114.diff
	Nov 11 2025, 8:39 PM

	F18626842: D9114.id21655.diff
	Sep 16 2025, 2:38 AM

	F18467159: D9114.diff
	Sep 2 2025, 11:50 AM

	F18218044: D9114.diff
	Aug 19 2025, 9:43 AM

	F18095504: D9114.id21655.diff
	Aug 8 2025, 12:11 AM

	F18095503: D9114.id21753.diff
	Aug 8 2025, 12:11 AM

	F18095502: D9114.id.diff
	Aug 8 2025, 12:11 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC38eda3e86bb3: Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class.

Summary

Since this method is only used within this class, it makes sense to move it here.

Test Plan

N/A

Diff Detail

Repository

Branch

lintengine-pep8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 454
Build 454: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21655.May 14 2014, 4:16 AM

joshuaspence retitled this revision from to Move `getPEP8WithTextOptions` method into `ComprehensiveLintEngine` class..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 14 2014, 4:16 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B454: Diff 21655.May 14 2014, 4:17 AM

D3882 explicitly moved this up after accept, but I don't know why. I assume it was just a generality thing since .arclint and similar were nowehere in sight.

epriestley accepted this revision.May 17 2014, 2:18 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 17 2014, 2:18 AM

Closed by commit rARC38eda3e86bb3 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

engine/

ArcanistLintEngine.php

9 lines

ComprehensiveLintEngine.php

9 lines

Diff 21655

src/lint/engine/ArcanistLintEngine.php

Loading...

src/lint/engine/ComprehensiveLintEngine.php

Loading...