Don't prompt for patches when outputting lint results as XML.
ClosedPublic
Actions

Authored by joshuaspence on May 13 2014, 9:39 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4948: Support checkstyle as an output format

Commits

rARC79285208c426: Don't prompt for patches when outputting lint results as XML.

Summary

The Checkstyle XML output format is not intended to be an interactive workflow.

Test Plan

Introduced linter issues and ran arc lint. Verified that no interactive prompt was shown.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 21638.May 13 2014, 9:39 PM

joshuaspence retitled this revision from to Don't prompt for patches when outputting lint results as XML..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2014, 9:39 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B441: Diff 21638.May 13 2014, 9:40 PM

epriestley accepted this revision.May 13 2014, 9:40 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 13 2014, 9:40 PM

Closed by commit rARC79285208c426 (authored by @joshuaspence, committed by @epriestley).

joshuaspence added a task: T4948: Support checkstyle as an output format.May 13 2014, 9:47 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistLintWorkflow.php

2 lines

Diff 21639

View Options

src/workflow/ArcanistLintWorkflow.php

Don't prompt for patches when outputting lint results as XML.ClosedPublicActions