Page MenuHomePhabricator
Differential D9107

Don't prompt for patches when outputting lint results as XML.
ClosedPublic
Actions

Authored by joshuaspence on May 13 2014, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 23, 9:46 AM
Unknown Object (File)
Mon, Dec 23, 9:46 AM
Unknown Object (File)
Mon, Dec 23, 9:46 AM
Unknown Object (File)
Mon, Dec 23, 9:45 AM
Unknown Object (File)
Sun, Dec 22, 2:25 AM
Unknown Object (File)
Sun, Dec 15, 7:08 AM
Unknown Object (File)
Fri, Dec 13, 10:40 AM
Unknown Object (File)
Wed, Dec 11, 2:34 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4948: Support checkstyle as an output format
Commits
rARC79285208c426: Don't prompt for patches when outputting lint results as XML.
Summary

The Checkstyle XML output format is not intended to be an interactive workflow.

Test Plan

Introduced linter issues and ran arc lint. Verified that no interactive prompt was shown.

Diff Detail

Repository
rARC Arcanist
Branch
checkstyle-patches
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 441
Build 441: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 21638.May 13 2014, 9:39 PM
joshuaspence retitled this revision from to Don't prompt for patches when outputting lint results as XML..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2014, 9:39 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B441: Diff 21638.May 13 2014, 9:40 PM
epriestley accepted this revision.May 13 2014, 9:40 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 13 2014, 9:40 PM
epriestley closed this revision.May 13 2014, 9:40 PM
epriestley updated this revision to Diff 21639.

Closed by commit rARC79285208c426 (authored by @joshuaspence, committed by @epriestley).

joshuaspence added a task: T4948: Support checkstyle as an output format.May 13 2014, 9:47 PM

Revision Contents
Changeset List

PathSize
src/
workflow/
2 lines

Diff 21638

View Options

src/workflow/ArcanistLintWorkflow.php

Loading...
Phabricator · Built by Phacility