Ref T2683. This is a small optimization, but it has low complexity: don't rebuild a bucket more than once in the same request, since it will almost always be the same. Bucket rebuilds are pretty cheap, but this saves a few queries.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T2683: Improve the performance of Diffusion browse views
- Commits
- Restricted Diffusion Commit
rP84fc8f0baf9f: Don't try to rebuild a repository graph cache bucket more than once per request
- After discovering (but before parsing) a commit, viewed its browse view. Verified that this patch causes us to perform only one bucket rebuild, and therefore reduces the number of queries we issue.
- Parsed the commit and viewed the browse view again, got successful rebuild and then fills from cache.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- gcache10
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 367 Build 367: [Placeholder Plan] Wait for 30 Seconds