Page MenuHomePhabricator

Don't try to rebuild a repository graph cache bucket more than once per request
ClosedPublic

Authored by epriestley on May 11 2014, 3:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 6:20 PM
Unknown Object (File)
Thu, Dec 19, 7:39 AM
Unknown Object (File)
Thu, Dec 19, 5:03 AM
Unknown Object (File)
Tue, Dec 17, 10:30 PM
Unknown Object (File)
Tue, Dec 17, 11:12 AM
Unknown Object (File)
Tue, Dec 17, 10:38 AM
Unknown Object (File)
Wed, Dec 11, 11:41 PM
Unknown Object (File)
Mon, Dec 9, 8:58 PM
Subscribers

Details

Summary

Ref T2683. This is a small optimization, but it has low complexity: don't rebuild a bucket more than once in the same request, since it will almost always be the same. Bucket rebuilds are pretty cheap, but this saves a few queries.

Test Plan
  • After discovering (but before parsing) a commit, viewed its browse view. Verified that this patch causes us to perform only one bucket rebuild, and therefore reduces the number of queries we issue.
  • Parsed the commit and viewed the browse view again, got successful rebuild and then fills from cache.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't try to rebuild a repository graph cache bucket more than once per request.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2014, 6:30 PM
epriestley updated this revision to Diff 21575.

Closed by commit rP84fc8f0baf9f (authored by @epriestley).