Minor updates to UIExamples
ClosedPublic
Actions

Authored by epriestley on Apr 20 2014, 9:14 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T4830: Applications with Public permissions requiring users to login

Commits

Restricted Diffusion Commit
rP4143ecf01571: Minor updates to UIExamples

Summary

Ref T4830.

If the application policy is public, allow logged-out users to browse examples.
Use standard elements instead of custom ones.

Test Plan

Browsed UIExamples.

Diff Detail

Repository

rP Phabricator

Branch

pub1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22
Build 22: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 20943.Apr 20 2014, 9:14 PM

epriestley retitled this revision from to Minor updates to UIExamples.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T4830: Applications with Public permissions requiring users to login.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 20 2014, 9:14 PM

chad accepted this revision.Apr 20 2014, 9:14 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2014, 9:14 PM

Harbormaster completed remote builds in B22: Diff 20943.Apr 20 2014, 9:15 PM

Closed by commit rP4143ecf01571 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

uiexample/

controller/

PhabricatorUIExampleRenderController.php

37 lines

webroot/

rsrc/

css/

application/

uiexample/

example.css

8 lines

Diff 20943

View Options

src/applications/uiexample/controller/PhabricatorUIExampleRenderController.php