Page MenuHomePhabricator

Remove indirect loads of Differential revisions from Releeph requests
ClosedPublic

Authored by epriestley on Apr 20 2014, 4:41 PM.
Tags
None
Referenced Files
F22601810: D8824.diff
Mon, Sep 28, 7:08 PM
Unknown Object (File)
Mon, Sep 14, 1:21 PM
Unknown Object (File)
Mon, Sep 14, 1:06 PM
Unknown Object (File)
Aug 23 2026, 12:46 AM
Unknown Object (File)
Jun 24 2026, 10:36 PM
Unknown Object (File)
Mar 22 2026, 8:47 PM
Unknown Object (File)
Mar 6 2026, 5:03 PM
Unknown Object (File)
Mar 4 2026, 10:32 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP28696d08ac42: Remove indirect loads of Differential revisions from Releeph requests
Summary

Ref T3551. Currently, there are many layers of indirection between pull requests and revisions. After D8822, revisions and other types of requested objects are recorded directly on the request. This allows us to simplify data access and querying.

A lot of stuff here is doing instanceof checks to keep APIs stable, but most of those can go away in the long run.

Test Plan
  • Browsed requests.
  • Verified revision-dependent fields (like "Revision", "Size", "Churn") still render correctly.
  • Called releeph.queryrequests.
  • Called releephwork.nextrequest.

Diff Detail

Repository
rP Phabricator
Branch
rel9
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21
Build 21: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Remove indirect loads of Differential revisions from Releeph requests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2014, 5:03 PM
epriestley updated this revision to Diff 20942.

Closed by commit rP28696d08ac42 (authored by @epriestley).