Page MenuHomePhabricator

Give Buildables a status, populate it, and return it over Conduit
ClosedPublic

Authored by epriestley on Apr 17 2014, 3:33 PM.
Tags
None
Referenced Files
F14394927: D8799.diff
Sun, Dec 22, 2:42 AM
F14390266: D8799.id20880.diff
Sat, Dec 21, 6:16 PM
F14390265: D8799.diff
Sat, Dec 21, 6:16 PM
Unknown Object (File)
Thu, Dec 19, 1:59 PM
Unknown Object (File)
Thu, Dec 12, 1:06 AM
Unknown Object (File)
Thu, Dec 12, 1:05 AM
Unknown Object (File)
Thu, Dec 12, 12:49 AM
Unknown Object (File)
Thu, Dec 12, 12:35 AM
Subscribers

Details

Summary

Ref T4809. Currently, buildables have a status field but nothing populates it. Populate it:

  • When builds change state, update the Buildable state.
  • Use the new Buildable state on the web UI.
  • Return the new Buildable state from Conduit.

To make it easier to debug/test this:

  • Provide bin/harbormaster update Bxxx ... to force foreground update of a Buildable.
Test Plan
  • Used bin/harbormaster update Bxxx --force --trace to update buildables.
  • Looked at buidlable list, saw statuses reported properly.
  • Used Conduit to read statuses.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Give Buildables a status, populate it, and return it over Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/harbormaster/conduit/ConduitAPI_harbormaster_sendmessage_Method.php
48–53

This basically does the same thing, but does it in the task queue so if we end up having to wait for the lock for a while it doesn't block the caller. I'd just forgotten that we already have this.

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php
56

We no longer need to load the builds because we can read the status directly from the Buildable.

src/applications/harbormaster/storage/HarbormasterBuildable.php
19

goodbye venerable "whatever" status

btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2014, 6:31 PM
epriestley updated this revision to Diff 20896.

Closed by commit rP0ef599e90676 (authored by @epriestley).