Page MenuHomePhabricator

Give Buildables a status, populate it, and return it over Conduit
ClosedPublic

Authored by epriestley on Apr 17 2014, 3:33 PM.
Tags
None
Referenced Files
F14006994: D8799.id20896.diff
Mon, Oct 28, 9:58 PM
F14006993: D8799.id.diff
Mon, Oct 28, 9:58 PM
F14006992: D8799.id20880.diff
Mon, Oct 28, 9:58 PM
F14006941: D8799.diff
Mon, Oct 28, 9:33 PM
F13994928: D8799.id20880.diff
Wed, Oct 23, 9:30 AM
F13987139: D8799.id20896.diff
Mon, Oct 21, 7:41 AM
F13983825: D8799.diff
Sun, Oct 20, 8:57 AM
F13977488: D8799.diff
Oct 18 2024, 6:47 PM
Subscribers

Details

Summary

Ref T4809. Currently, buildables have a status field but nothing populates it. Populate it:

  • When builds change state, update the Buildable state.
  • Use the new Buildable state on the web UI.
  • Return the new Buildable state from Conduit.

To make it easier to debug/test this:

  • Provide bin/harbormaster update Bxxx ... to force foreground update of a Buildable.
Test Plan
  • Used bin/harbormaster update Bxxx --force --trace to update buildables.
  • Looked at buidlable list, saw statuses reported properly.
  • Used Conduit to read statuses.

Diff Detail

Repository
rP Phabricator
Branch
hm4
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley retitled this revision from to Give Buildables a status, populate it, and return it over Conduit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/harbormaster/conduit/ConduitAPI_harbormaster_sendmessage_Method.php
48–52

This basically does the same thing, but does it in the task queue so if we end up having to wait for the lock for a while it doesn't block the caller. I'd just forgotten that we already have this.

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php
56

We no longer need to load the builds because we can read the status directly from the Buildable.

src/applications/harbormaster/storage/HarbormasterBuildable.php
19

goodbye venerable "whatever" status

btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2014, 6:31 PM
epriestley updated this revision to Diff 20896.

Closed by commit rP0ef599e90676 (authored by @epriestley).