Page MenuHomePhabricator
Differential D8749

Herald - make tokenizers have the purdy icons
ClosedPublic
Actions

Authored by btrahan on Apr 10 2014, 7:33 PM.
Tags
None
Referenced Files
F13210026: D8749.id.diff
Fri, May 17, 3:26 AM
Unknown Object (File)
Thu, May 2, 2:43 PM
Unknown Object (File)
Thu, Apr 25, 7:35 AM
Unknown Object (File)
Fri, Apr 19, 12:28 PM
Unknown Object (File)
Apr 16 2024, 1:58 PM
Unknown Object (File)
Apr 16 2024, 1:57 PM
Unknown Object (File)
Apr 16 2024, 1:57 PM
Unknown Object (File)
Apr 16 2024, 1:51 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T4775: Typeaheads in Herald don't have the little icon next to them
Commits
Restricted Diffusion Commit
rP4b56dbed3a72: Herald - make tokenizers have the purdy icons
Summary

...use the prefab stuff as it does fancier things than we were doing. Only trick then really is to pass username and the map of handle phids => icons to the client so prefab can work nicely. Fixes T4775.

Test Plan

made a herald rule with projects and users. Saw nice icons. Reloaded page and still saw nice icons.

Diff Detail

Repository
rP Phabricator
Branch
T4775
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

btrahan updated this revision to Diff 20749.Apr 10 2014, 7:33 PM
btrahan added a task: T4775: Typeaheads in Herald don't have the little icon next to them.
btrahan retitled this revision from to Herald - make tokenizers have the purdy icons.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley.Apr 10 2014, 7:33 PM
btrahan updated this revision to Diff 20750.Apr 10 2014, 7:35 PM

remove spurious if (build) check

epriestley accepted this revision.Apr 10 2014, 7:37 PM
epriestley edited edge metadata.

Oh, nice! This is way cleaner.

This revision is now accepted and ready to land.Apr 10 2014, 7:37 PM
btrahan closed this revision.Apr 10 2014, 7:38 PM
btrahan updated this revision to Diff 20751.

Closed by commit rP4b56dbed3a72 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
resources/
celerity/
37 lines
src/
applications/
herald/
controller/
6 lines
webroot/
rsrc/
js/
application/
herald/
24 lines

Diff 20750

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

webroot/rsrc/js/application/herald/HeraldRuleEditor.js

Loading...
Phabricator · Built by Phacility