Page MenuHomePhabricator

Herald - make tokenizers have the purdy icons
ClosedPublic

Authored by btrahan on Apr 10 2014, 7:33 PM.
Tags
None
Referenced Files
F14101471: D8749.diff
Tue, Nov 26, 4:19 PM
Unknown Object (File)
Oct 24 2024, 11:28 AM
Unknown Object (File)
Oct 23 2024, 9:13 PM
Unknown Object (File)
Oct 22 2024, 6:15 PM
Unknown Object (File)
Oct 22 2024, 6:14 PM
Unknown Object (File)
Oct 16 2024, 9:25 PM
Unknown Object (File)
Oct 16 2024, 12:15 PM
Unknown Object (File)
Oct 14 2024, 1:09 PM
Subscribers

Details

Summary

...use the prefab stuff as it does fancier things than we were doing. Only trick then really is to pass username and the map of handle phids => icons to the client so prefab can work nicely. Fixes T4775.

Test Plan

made a herald rule with projects and users. Saw nice icons. Reloaded page and still saw nice icons.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Herald - make tokenizers have the purdy icons.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.

remove spurious if (build) check

epriestley edited edge metadata.

Oh, nice! This is way cleaner.

This revision is now accepted and ready to land.Apr 10 2014, 7:37 PM
btrahan updated this revision to Diff 20751.

Closed by commit rP4b56dbed3a72 (authored by @btrahan).