Page MenuHomePhabricator

Add a priorityColor property to the maniphest conduit endpoint
ClosedPublic

Authored by bwinterton on Apr 9 2014, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 7:08 AM
Unknown Object (File)
Fri, Dec 13, 3:13 AM
Unknown Object (File)
Sun, Dec 8, 7:31 PM
Unknown Object (File)
Wed, Dec 4, 9:20 PM
Unknown Object (File)
Tue, Dec 3, 9:11 PM
Unknown Object (File)
Sun, Dec 1, 5:00 PM
Unknown Object (File)
Tue, Nov 26, 10:30 PM
Unknown Object (File)
Tue, Nov 26, 6:19 PM
Subscribers

Details

Summary

I added a getTaskPriorityColor function to the ManiphestTaskPriority class which returns the color set in the maniphest config for the given priority.

This is in preparation for a change to arcanist which will allow it to display the priority color (if it is a supported color) upon running arc tasks.

Fixed some linting issues

Test Plan

Invoke the maniphest.info method from conduit and ensure that:

  • The priorityColor property is given in the json
  • the priorityColor property is set correctly

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

bwinterton retitled this revision from to Add a priorityColor property to the maniphest conduit endpoint.
bwinterton updated this object.
bwinterton edited the test plan for this revision. (Show Details)
bwinterton added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 9 2014, 6:31 PM
epriestley updated this revision to Diff 20717.

Closed by commit rPb660960771a4 (authored by @bwinterton, committed by @epriestley).