Page MenuHomePhabricator

Add a priorityColor property to the maniphest conduit endpoint
ClosedPublic

Authored by bwinterton on Apr 9 2014, 6:02 PM.
Tags
None
Referenced Files
F13251787: D8734.diff
Sat, May 25, 12:45 AM
F13249950: D8734.id.diff
Fri, May 24, 12:13 PM
F13227056: D8734.id20714.diff
Mon, May 20, 1:02 AM
F13210710: D8734.id20717.diff
Fri, May 17, 5:07 AM
F13210708: D8734.id20714.diff
Fri, May 17, 5:07 AM
F13202564: D8734.diff
Tue, May 14, 10:51 PM
F13198483: D8734.id20714.diff
Mon, May 13, 7:09 AM
F13185305: D8734.diff
Sat, May 11, 2:47 AM
Subscribers

Details

Summary

I added a getTaskPriorityColor function to the ManiphestTaskPriority class which returns the color set in the maniphest config for the given priority.

This is in preparation for a change to arcanist which will allow it to display the priority color (if it is a supported color) upon running arc tasks.

Fixed some linting issues

Test Plan

Invoke the maniphest.info method from conduit and ensure that:

  • The priorityColor property is given in the json
  • the priorityColor property is set correctly

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

bwinterton retitled this revision from to Add a priorityColor property to the maniphest conduit endpoint.
bwinterton updated this object.
bwinterton edited the test plan for this revision. (Show Details)
bwinterton added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 9 2014, 6:31 PM
epriestley updated this revision to Diff 20717.

Closed by commit rPb660960771a4 (authored by @bwinterton, committed by @epriestley).