Page MenuHomePhabricator
Differential D8727

Switch back to zwsp for oncopy line marker
ClosedPublic
Actions

Authored by sophiebits on Apr 9 2014, 12:50 AM.
Tags
None
Referenced Files
F13086551: D8727.diff
Thu, Apr 25, 12:36 AM
Unknown Object (File)
Sat, Apr 20, 6:45 PM
Unknown Object (File)
Sat, Apr 20, 1:39 AM
Unknown Object (File)
Wed, Apr 17, 2:14 PM
Unknown Object (File)
Thu, Apr 4, 1:48 PM
Unknown Object (File)
Tue, Apr 2, 10:59 AM
Unknown Object (File)
Sat, Mar 30, 11:32 AM
Unknown Object (File)
Fri, Mar 29, 3:05 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4759: Zero space unicode word joiner is causing ? utf characters in DifferentialChangesetTwoUpRenderer
Commits
Restricted Diffusion Commit
rPa7272dfb03d0: Switch back to zwsp for oncopy line marker
Summary

Fixes T4759.

Turns out Chrome on windows doesn't really like the word joiner character. We'll switch back to zwsp but make it position: absolute; so it doesn't turn into a line break.

Test Plan

Looked at diffs in IE9 and Chrome Windows. Made sure copying still works as expected.

Diff Detail

Repository
rP Phabricator
Branch
zwsp
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

sophiebits updated this revision to Diff 20694.Apr 9 2014, 12:50 AM
sophiebits retitled this revision from to Switch back to zwsp for oncopy line marker.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.
sophiebits added a task: T4715: Move Audit to ApplicationSearch.
Herald added reviewers: Blessed Reviewers, chad.Apr 9 2014, 12:50 AM
Herald added subscribers: Korvin, epriestley.
epriestley updated this object.Apr 9 2014, 12:52 AM
epriestley edited edge metadata.
epriestley added a task: T4759: Zero space unicode word joiner is causing ? utf characters in DifferentialChangesetTwoUpRenderer.
sophiebits added a comment.Apr 9 2014, 12:52 AM

Oops, sorry for mixing up the task IDs.

epriestley accepted this revision.Apr 9 2014, 12:55 AM
epriestley edited edge metadata.

The web is a house of cards built on quicksand.

This revision is now accepted and ready to land.Apr 9 2014, 12:55 AM
epriestley closed this revision.Apr 9 2014, 12:56 AM
epriestley updated this revision to Diff 20695.

Closed by commit rPa7272dfb03d0 (authored by @spicyj, committed by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
src/
applications/
differential/
render/
14 lines
diffusion/
controller/
2 lines
view/
layout/
2 lines
webroot/
rsrc/
css/
application/
differential/
5 lines
js/
core/
2 lines

Diff 20694

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
View Options

src/view/layout/PhabricatorSourceCodeView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/js/core/behavior-oncopy.js

Loading...
Phabricator · Built by Phacility