Audit should use ApplicationSearch.
Description
Description
Revisions and Commits
Revisions and Commits
rP Phabricator | |||
D8879 | rP16648c28bcd7 Add GROUP BY to commit query | ||
D8880 | rP9da255efaa78 Add a "problem commits" prebuilt filter to Audits | ||
D8805 | rP2ecc04c159b0 Audit - move over to application search |
Status | Assigned | Task | ||
---|---|---|---|---|
Duplicate | None | T4713 More searching options for audit | ||
Resolved | epriestley | T2881 Make Audit tables sortable | ||
Resolved | epriestley | T4889 Commit summaries affiliated with policy-restricted repos are visible to users not in the policy to which the repo is restricted | ||
Resolved | btrahan | T4715 Move Audit to ApplicationSearch |
Event Timeline
Comment Actions
From https://github.com/facebook/phabricator/issues/562
- Allow searching by particular branches (git, hg) within a repository.
From that and T4713:
- Allow searching by particular paths (git, hg, svn) within a repository.
Comment Actions
There's probably a bunch of work here, but we can get started on all of it by moving Audit to ApplicationSearch. In general:
- Audit has two views now. One queries audits, the other queries commits by audit status. I think we should basically throw out the audit view and make all the queries return commits. To find relevant audits, you're searching for commits which have some relevant audit state or auditors. Particularly, searching by audit can currently show the same commit multiple times (if it has multiple auditors) which is fairly confusing.
- Broadly, this means PhabricatorAuditQuery should do less, and probably lose some methods. It should also become PolicyAware. It's possible it should be removed entirely, and just become a needAudits() or similar.
- PhabricatorAuditCommitQuery should merge into DiffusionCommitQuery and eventually die.
- We'll end up with a single, cohesive ApplicationSearch view with some default queries like "Need Attention" (commits with open audits the viewer is responsible for), "Open Audits" (commits with open audits) and "All Commits" (commits with no other filters) that is simpler and more powerful than the whole mess we have now.
Comment Actions
Pulling
From https://github.com/facebook/phabricator/issues/562
Allow searching by particular branches (git, hg) within a repository.
Into T4713