Page MenuHomePhabricator

Switch back to zwsp for oncopy line marker
ClosedPublic

Authored by sophiebits on Apr 9 2014, 12:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 4:07 PM
Unknown Object (File)
Nov 24 2024, 9:59 PM
Unknown Object (File)
Nov 23 2024, 2:35 AM
Unknown Object (File)
Nov 21 2024, 12:59 PM
Unknown Object (File)
Nov 20 2024, 9:38 PM
Unknown Object (File)
Nov 20 2024, 12:51 AM
Unknown Object (File)
Nov 17 2024, 1:57 AM
Unknown Object (File)
Nov 16 2024, 8:21 PM
Subscribers

Details

Summary

Fixes T4759.

Turns out Chrome on windows doesn't really like the word joiner character. We'll switch back to zwsp but make it position: absolute; so it doesn't turn into a line break.

Test Plan

Looked at diffs in IE9 and Chrome Windows. Made sure copying still works as expected.

Diff Detail

Repository
rP Phabricator
Branch
zwsp
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

sophiebits retitled this revision from to Switch back to zwsp for oncopy line marker.
sophiebits updated this object.
sophiebits edited the test plan for this revision. (Show Details)
sophiebits added a reviewer: epriestley.

Oops, sorry for mixing up the task IDs.

epriestley edited edge metadata.

The web is a house of cards built on quicksand.

This revision is now accepted and ready to land.Apr 9 2014, 12:55 AM
epriestley updated this revision to Diff 20695.

Closed by commit rPa7272dfb03d0 (authored by @spicyj, committed by @epriestley).