Page MenuHomePhabricator

Herald - fix change type bug
ClosedPublic

Authored by btrahan on Apr 8 2014, 6:54 PM.
Tags
None
Referenced Files
F14351709: D8724.diff
Thu, Dec 19, 9:42 AM
Unknown Object (File)
Sun, Dec 15, 9:14 AM
Unknown Object (File)
Fri, Dec 13, 10:53 AM
Unknown Object (File)
Sun, Dec 8, 1:16 PM
Unknown Object (File)
Sat, Dec 7, 5:10 PM
Unknown Object (File)
Tue, Dec 3, 5:11 PM
Unknown Object (File)
Sat, Nov 30, 5:29 AM
Unknown Object (File)
Fri, Nov 29, 2:46 PM
Subscribers

Details

Summary

wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan

created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Herald - fix change type bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 8 2014, 6:57 PM
btrahan updated this revision to Diff 20689.

Closed by commit rPd5ded805b2d3 (authored by @btrahan).