Page MenuHomePhabricator

Herald - fix change type bug
ClosedPublic

Authored by btrahan on Apr 8 2014, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 28 2026, 6:57 PM
Unknown Object (File)
Feb 3 2026, 8:12 PM
Unknown Object (File)
Jan 18 2026, 8:43 PM
Unknown Object (File)
Jan 9 2026, 4:46 PM
Unknown Object (File)
Dec 30 2025, 7:11 PM
Unknown Object (File)
Dec 23 2025, 2:49 PM
Unknown Object (File)
Dec 22 2025, 10:40 PM
Unknown Object (File)
Nov 14 2025, 8:33 PM
Subscribers

Details

Summary

wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan

created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Herald - fix change type bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 8 2014, 6:57 PM
btrahan updated this revision to Diff 20689.

Closed by commit rPd5ded805b2d3 (authored by @btrahan).