Page MenuHomePhabricator

Herald - fix change type bug
ClosedPublic

Authored by btrahan on Apr 8 2014, 6:54 PM.
Tags
None
Referenced Files
F19300712: D8724.id.diff
Tue, Dec 23, 2:49 PM
F19271021: D8724.diff
Mon, Dec 22, 10:40 PM
F18967178: D8724.diff
Nov 14 2025, 8:33 PM
F18869276: D8724.id20689.diff
Nov 4 2025, 10:50 AM
F18829002: D8724.diff
Oct 24 2025, 7:13 PM
F18757403: D8724.id20689.diff
Oct 5 2025, 5:20 PM
F18757387: D8724.id20687.diff
Oct 5 2025, 5:15 PM
F18091479: D8724.id20689.diff
Aug 6 2025, 9:56 PM
Subscribers

Details

Summary

wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan

created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Diff Detail

Repository
rP Phabricator
Branch
T4756
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan retitled this revision from to Herald - fix change type bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 8 2014, 6:57 PM
btrahan updated this revision to Diff 20689.

Closed by commit rPd5ded805b2d3 (authored by @btrahan).