Page MenuHomePhabricator

Make contextual matching of project monograms more liberal
ClosedPublic

Authored by epriestley on Apr 4 2014, 5:54 PM.
Tags
None
Referenced Files
F15481345: D8703.id20641.diff
Tue, Apr 8, 8:11 PM
F15475485: D8703.id20641.diff
Sun, Apr 6, 7:56 PM
F15475100: D8703.id20638.diff
Sun, Apr 6, 3:52 PM
F15475099: D8703.id20641.diff
Sun, Apr 6, 3:52 PM
F15422493: D8703.id20641.diff
Sat, Mar 22, 8:45 AM
F15421473: D8703.id.diff
Sat, Mar 22, 12:05 AM
F15415369: D8703.id20638.diff
Thu, Mar 20, 5:38 AM
F15411367: D8703.diff
Wed, Mar 19, 9:14 AM
Subscribers

Details

Summary

We currently share the same regexp between PHID matching (usually unambiguous) and remarkup matching (often ambiguous).

This means that some project monograms which should work fine don't work properly in some contexts. Improve these behaviors.

For example:

  • #domain.com
    • Previously did not work at all.
    • Now works in unambiguous cases, and in remarkup.
  • #1
    • Previously did not work at all.
    • Now works in unambiguous cases.
  • #dot.
    • Previously did not work at all.
    • Now works in unambiguous cases.
Test Plan
  • Created projects domain.com, 1, etc.
  • Used jump nav to match them unambiguously, everything worked.
  • Used remarkup preview to match them ambiguously, the reasonable ones worked.

Diff Detail

Repository
rP Phabricator
Branch
pmonogram
Lint
Lint Passed
Unit
No Test Coverage