...the key is to move a layer lower and beam down the updated comment. There is a wee bit of Javascript gymnastics going on here. Fixes T4608.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T4608: When you edit a comment, it ajaxes in wrong if it's part of a comment group
- Commits
- Restricted Diffusion Commit
rP496a7d8967e2: Transactions - make edit transactions that are grouped work nicely
made a comment + resolve. clicked edit and made changes. noted transaction updated correctly and "history" link worked. edited again to a deletion and noted the "this is deleted" looked right and history link still worked
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T4608
- Lint
Lint Errors Severity Location Code Message Error webroot/rsrc/js/application/transactions/behavior-transaction-list.js:90 TXT5 Bad Charset - Unit
Tests Passed
Event Timeline
Comment Actions
move funky chars to a constant that send to JS land via config
include javelin-util and rebuild celerity
Comment Actions
Does this work properly with inlines in Differential and Pholio? Those both override renderTransactionContent() but it looks like they might not be accounted for?
This looks good to me otherwise, but I think that needs to be tweaked a bit.
Comment Actions
make these changes diffusion / pholio aware
- revert "Content" => "Comment" since it makes more sense as "Content" in broader context
- update pholio css ever so slightly to style new wrapper span correctly.
- update JS ever so slightly to expect a "set" of comments, and just use the first one.