Page MenuHomePhabricator

When you edit a comment, it ajaxes in wrong if it's part of a comment group
Closed, ResolvedPublic

Description

If transactions are grouped (e.g., accept + comment), and you edit the comment, we get the ajaxing in wrong when replacing it.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Transactions.
epriestley added a subscriber: epriestley.

◀ Merged tasks: T4667.

This is minor, but super user-visible, since like half of edits produce completely broken UI. Currently, I think the logic goes like:

  • Send a request to the server.
  • Server sends back the entire box.
  • Replace the entire box.

However, the "entire box" can have a lot of other junk in it now that the server really has no idea how to render from just the comment. Instead of trying to render the whole box, we should probably do this:

  • Send a request to the server.
  • Server sends back just the text.
  • Replace just the text.
  • Maybe also change the "Edit" link to say "Edited" or whatever.
btrahan edited this Maniphest Task.Apr 4 2014, 5:50 PM
btrahan edited this Maniphest Task.Apr 4 2014, 7:23 PM
btrahan closed this task as Resolved.Apr 4 2014, 7:23 PM

Closed by commit rP496a7d8967e2.