Page MenuHomePhabricator

Allow users to choose what types of buildables they want to publish fragments for
AbandonedPublic

Authored by hach-que on Mar 29 2014, 4:05 AM.
Tags
None
Referenced Files
F14007728: D8641.diff
Tue, Oct 29, 10:38 AM
F13969217: D8641.id.diff
Thu, Oct 17, 1:15 AM
Unknown Object (File)
Wed, Oct 9, 3:45 PM
Unknown Object (File)
Oct 5 2024, 4:07 PM
Unknown Object (File)
Oct 1 2024, 1:46 AM
Unknown Object (File)
Sep 23 2024, 7:24 PM
Unknown Object (File)
Sep 20 2024, 6:25 PM
Unknown Object (File)
Sep 20 2024, 6:22 PM

Details

Summary

Supersedes D7750.

Essentially the same thing but on the new field infrastructure. I did want to make this work for all steps while I was at it, but since the fields are now drawn from the step configuration, I'm not sure what the right way to go about this (should I modify the steps to include a call to the parent for "global fields"? Or should I modify the build step edit to forcefully include the field there?)

Test Plan

Tested against combinations of commits and revisions

Diff Detail

Repository
rP Phabricator
Branch
buildable-filter
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

hach-que retitled this revision from to Allow users to choose what types of buildables they want to publish fragments for.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldBuildableType.php
10–61

This is almost certainly incorrect, but I don't know how these functions behave in the context of application search.

hach-que edited edge metadata.

Rebase on master

epriestley edited edge metadata.

This should wait for T5877, and is probably obsoleted by it.

This revision now requires changes to proceed.May 13 2015, 1:53 PM

Yes, it definitely is obsoleted by Embed Build Plan.