Differential D8536
Improve error and large file handling in thumbnailing Authored by epriestley on Mar 14 2014, 5:11 PM. Tags None Referenced Files
Subscribers
Details
Ref T2479, T4406. We should do a better job of (a) handling image processing errors and (b) declining to process large image files. This fixes the worst of it, which is that users can upload huge GIFs with a large number of frames and hang a convert process for a long time, eating a CPU and a pile of memory. This code is still pretty iffy and needs some more work. A near-term product goal for it is supporting 100x100 profile images. Uploaded large and small GIFs, after setting the definition of "enormous" to be pretty small. Saw the small GIFs thumbnail into animated GIFs, and the large ones thumbnail into static images.
Diff Detail
Event TimelineComment Actions We're still vulnerable to users uploading really huge PNGs, in that we'll spend far more resources processing them than the attacker requires to upload them, but I'd like to update this code more comprehensively before trying to fix that. |