Page MenuHomePhabricator

Don't close revisions on "arc amend"
ClosedPublic

Authored by epriestley on Mar 14 2014, 12:32 AM.
Tags
None
Referenced Files
F13280838: D8522.diff
Sun, Jun 2, 9:22 AM
F13267204: D8522.diff
Wed, May 29, 2:59 AM
F13257151: D8522.id20219.diff
Sat, May 25, 8:51 PM
F13252626: D8522.diff
Sat, May 25, 1:54 AM
F13230348: D8522.diff
Mon, May 20, 10:52 PM
F13214877: D8522.id.diff
Fri, May 17, 1:31 PM
F13200803: D8522.id.diff
Tue, May 14, 3:42 AM
F13191202: D8522.diff
Sat, May 11, 6:02 PM
Subscribers

Details

Summary

Ref T4603. This workflow predates arc land and doesn't make much sense in modern Phabricator/Arcanist. It is surprising that arc amend will sometimes close accepted revisions, and we're better at detecting that repositories are tracked, and tracking repositories is easier.

Also fix some inaccuracies and old claims in the documenation and help.

Test Plan

Ran arc amend.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't close revisions on "arc amend".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 12:41 AM
epriestley updated this revision to Diff 20225.

Closed by commit rARC03ddc1703245 (authored by @epriestley).