Page MenuHomePhabricator

Remove the `close-revision --finalize` hook from "arc amend"
Closed, ResolvedPublic


  • arc amend has a surprising side effect of closing revisions in some cases. This made sense long ago, before arc land, but makes no sense in modern workflows. Let's just remove the side effect entirely.
  • arc land does similar things, but probably isn't calling the newest code to check for a repositoryPHID. It should be updated. I think the side effect is OK here.

Related Objects

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Arcanist.
epriestley added subscribers: epriestley, zeeg.
epriestley edited this Maniphest Task.