Page MenuHomePhabricator
Create Task
Maniphest T4603

Remove the `close-revision --finalize` hook from "arc amend"
Closed, ResolvedPublic
Actions

Description

  • arc amend has a surprising side effect of closing revisions in some cases. This made sense long ago, before arc land, but makes no sense in modern workflows. Let's just remove the side effect entirely.
  • arc land does similar things, but probably isn't calling the newest code to check for a repositoryPHID. It should be updated. I think the side effect is OK here.

Revisions and Commits

rARC Arcanist
D8523rARC1e6d958b27df Use more modern detection of repositories in "arc close-revision"
D8522rARC03ddc1703245 Don't close revisions on "arc amend"

Related Objects

Event Timeline

epriestley created this task.Mar 13 2014, 9:38 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Arcanist.
epriestley added subscribers: epriestley, zeeg.
epriestley edited this Maniphest Task.Mar 14 2014, 12:32 AM
epriestley edited this Maniphest Task.Mar 14 2014, 12:38 AM
epriestley edited this Maniphest Task.Mar 14 2014, 1:00 AM
epriestley edited this Maniphest Task.
epriestley closed this task as Resolved.Mar 14 2014, 1:01 AM

Closed by commit rARC1e6d958b27df.

epriestley added a subscriber: brent.Mar 14 2014, 2:39 AM

◀ Merged tasks: T4169.

Phabricator · Built by Phacility