Page MenuHomePhabricator
Differential D8502

Add a "tags" field to Diffusion commit
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 4:53 PM.
Tags
None
Referenced Files
F13328144: D8502.diff
Sun, Jun 16, 5:21 AM
F13326273: D8502.id20170.diff
Sat, Jun 15, 3:25 AM
F13316847: D8502.diff
Thu, Jun 13, 8:42 AM
F13304193: D8502.diff
Sat, Jun 8, 8:43 AM
F13285877: D8502.diff
Tue, Jun 4, 4:13 AM
F13252614: D8502.diff
Sat, May 25, 1:53 AM
F13230512: D8502.diff
Mon, May 20, 11:01 PM
F13210250: D8502.diff
May 17 2024, 4:39 AM
View All Files
Subscribers
aran
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4588: Add "branches" / "tags" information in Diffusion commit emails
Commits
Restricted Diffusion Commit
rPa4a4322d7abf: Add a "tags" field to Diffusion commit
Summary
  • Fixes T4588.
  • See D8501.
  • Adds a "Tags" field for Herald commit emails.
  • Fixes a bug in tagsquery when filtering by commit name.
  • Make tagsquery just return nothing instead of fataling against Mercurial/Subversion.
Test Plan

Used bin/repository/reparse.php --herald to exercise this code.

Diff Detail

Repository
rP Phabricator
Branch
morefields2
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Diff 20170.Mar 12 2014, 4:53 PM
epriestley retitled this revision from to Add a "tags" field to Diffusion commit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4588: Add "branches" / "tags" information in Diffusion commit emails.
Herald added subscribers: epriestley, aran.Mar 12 2014, 4:53 PM
btrahan accepted this revision.Mar 12 2014, 6:16 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 6:16 PM
epriestley closed this revision.Mar 12 2014, 6:30 PM
epriestley updated this revision to Diff 20178.

Closed by commit rPa4a4322d7abf (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
conduit/
17 lines
repository/
customfield/
37 lines
worker/
11 lines

Diff 20170

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/conduit/ConduitAPI_diffusion_tagsquery_Method.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitTagsField.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Loading...
Phabricator · Built by Phacility