Page MenuHomePhabricator
Differential D8501

Add CustomField to Diffusion and add a "branches" field
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 4:36 PM.
Tags
None
Referenced Files
F13265188: D8501.id20169.diff
Tue, May 28, 1:51 AM
F13230091: D8501.id.diff
Mon, May 20, 8:43 PM
F13222280: D8501.diff
Sun, May 19, 3:28 AM
F13214344: D8501.id20168.diff
Fri, May 17, 9:58 AM
F13203390: D8501.diff
Tue, May 14, 11:42 PM
F13192541: D8501.id20177.diff
Sun, May 12, 8:36 AM
F13192540: D8501.id20169.diff
Sun, May 12, 8:36 AM
F13192539: D8501.id20168.diff
Sun, May 12, 8:36 AM
View All Files
Subscribers
aran
epriestley
zeeg

Details

Reviewers
btrahan
Maniphest Tasks
T4588: Add "branches" / "tags" information in Diffusion commit emails
Commits
Restricted Diffusion Commit
rP611f6707204c: Add CustomField to Diffusion and add a "branches" field
Summary

Ref T4588. Request from @zeeg. Adds a "BRANCHES" field to commit emails, so the branches the commit appears on are shown.

I've implemented this with CustomField, but in a very light way.

Test Plan

Used scripts/repository/reparse.php --herald to generate mail, got a BRANCHES section where applicable.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20168.Mar 12 2014, 4:36 PM
epriestley retitled this revision from to Add CustomField to Diffusion and add a "branches" field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4588: Add "branches" / "tags" information in Diffusion commit emails.
epriestley added a subscriber: zeeg.
Herald added subscribers: epriestley, aran.Mar 12 2014, 4:36 PM
epriestley updated this revision to Diff 20169.Mar 12 2014, 4:37 PM
  • Remove some dead code.
btrahan accepted this revision.Mar 12 2014, 6:15 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 6:15 PM
epriestley closed this revision.Mar 12 2014, 6:30 PM
epriestley updated this revision to Diff 20177.

Closed by commit rP611f6707204c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
5 lines
applications/
repository/
customfield/
37 lines
7 lines
storage/
27 lines
worker/
17 lines
infrastructure/
customfield/
field/
18 lines

Diff 20177

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitBranchesField.php

Loading...
View Options

src/applications/repository/customfield/PhabricatorCommitCustomField.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
Phabricator · Built by Phacility